Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Charts - Top of chart cut off if data contains floats #2534

Closed
ziegenberg opened this issue Jul 2, 2011 · 6 comments
Closed

Charts - Top of chart cut off if data contains floats #2534

ziegenberg opened this issue Jul 2, 2011 · 6 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone
1.5.1

Comments

@ziegenberg
Copy link
Contributor

In the Visitor Overview the Chart showing the actions per visit is cut off at the top.

I debugged through Chart.php and found the problem there. All the dates in Chart.php Line 133 are kind of floats with a comma as the decimal mark and the json_encode() three lines further creates rubbish as it takes the comma as a separator.
@ziegenberg
Copy link
Contributor Author

The comma as decimal mark is the same reason why the calculation in getMaxValue() does not work.

@robocoder
Copy link
Contributor

Yeah, I suspected this just after committing [4963]. I'll revert and find the root cause.

@robocoder
Copy link
Contributor

(In [4967]) fixes #2534 (I think)...output looked ok with de_DE.UTF-8

@robocoder
Copy link
Contributor

[4967] fixed a bug in the json_encode compatibility function for floats

@ziegenberg
Copy link
Contributor Author

Patched my system. Works!

@vipsoft: Thanks for fixing this bug! I really appreciate your short response time.

@robocoder
Copy link
Contributor

Thanks for confirming.

@ziegenberg ziegenberg added this to the 1.5.1 Piwik 1.5.1 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Milestone
1.5.1
Development

No branches or pull requests
2 participants
@ziegenberg @robocoder