Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.travel TLD not supported #2535

Closed
anonymous-matomo-user opened this issue Jul 4, 2011 · 3 comments
Closed

.travel TLD not supported #2535

anonymous-matomo-user opened this issue Jul 4, 2011 · 3 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@anonymous-matomo-user
Copy link

Currently the TLD .travel is not supported under e-mail reports. When trying to add additional e-mail addresses for "Send report to:" Piwik gives the following error: "The email doesn't have a valid format. (person@domain.travel)"

Please could you add .travel to the TLD array.

Thanks

@halfdan
Copy link
Member

halfdan commented Jul 4, 2011

This is quite easy to fix, in core/Piwik.php:

return (preg_match('/^[a-zA-Z0-9_.+-]+@[a-zA-Z0-9_.-]+\.[a-zA-Z]{2,4}$/', $email) > 0);

should actually be

return (preg_match('/^[a-zA-Z0-9_.+-]+@[a-zA-Z0-9_.-]+\.[a-zA-Z]{2,6}$/', $email) > 0);

.museum/.travel and others are currently not accepted as valid TLDs by the regex above.

@robocoder
Copy link
Contributor

We also have internationalized tlds to address in #1755. Maybe address boyh tickeys at the same time, eg using ZF hostname validator.

@mattab
Copy link
Member

mattab commented Sep 27, 2011

(In [5239]) Fixes #2535

@anonymous-matomo-user anonymous-matomo-user added this to the 1.6 Piwik 1.6 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

4 participants