Opened 3 years ago

Closed 3 years ago

#2569 closed Bug (fixed)

Google Mobile Image Search not recognized

Reported by: SteveG Owned by:
Priority: normal Milestone: 1.6 Piwik 1.6
Component: Core Keywords:
Cc: Sensitive: no

Description

The mobile image search of google is not detected at all:

http://www.google.com/m/imgres?gl=fr&source=mog&client=ms-android-google&q=piwik&hl=fr&start=0&site=images&imgid=ANd9GcQxUscuUydTOpon0arCcnJsjK4HF4CHQe1xB72QGlnC4GOYD3duGPPHtqFU&imgsz=139568&imgurl=http://piwik.org/wp-content/uploads/2008/11/piwik-e280ba-web-analytics-reports7.png&imgrefurl=http://fr.piwik.org/&ht=367&wd=622&tbnh=80&tbnw=136&ei=bgUiTvikOtPo8QPlgruUAw&ved=0CAkQ9QEwAA

Problem seems to be the special handling for google image search in core/Common.php:

if($searchEngineName === 'Google Images'
	|| ($searchEngineName === 'Google' && strpos($referrerUrl, '/imgres') !== false) )
{
	$query = urldecode(trim(self::getParameterFromQueryString($query, 'prev')));
	$query = str_replace('&', '&', strstr($query, '?'));
	$searchEngineName = 'Google Images';
}

/imageres is in the url, but there is no prev parameter...

Attachments (1)

gi.diff (829 bytes) - added by gatordog 3 years ago.
Associated Patch

Download all attachments as: .zip

Change History (4)

comment:1 Changed 3 years ago by gatordog

Here is a patch I'm using to identify these searches as Google Images. Replace 1385-1391 block in Common.php (from trunk)

        if($searchEngineName === 'Google Images'
    || ($searchEngineName === 'Google' && strpos($referrerUrl, '/imgres') !== false) )
        {
            if(strpos($referrerUrl, '&prev=') !== false)
            {
                $query = urldecode(trim(self::getParameterFromQueryString($query, 'prev')));
                $query = str_replace('&', '&', strstr($query, '?'));
            }
	    $searchEngineName = 'Google Images';
	}

Changed 3 years ago by gatordog

Associated Patch

comment:2 Changed 3 years ago by gatordog

The unit test patch for this is on the forum:
http://forum.piwik.org/read.php?2,80107

comment:3 Changed 3 years ago by vipsoft (robocoder)

  • Resolution set to fixed
  • Status changed from new to closed

(In [5143]) fixes #2569, fixes #2616, refs #2652, adds Google Video

Note: See TracTickets for help on using tickets.