Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google Mobile Image Search not recognized #2569

Closed
sgiehl opened this issue Jul 17, 2011 · 4 comments
Closed

Google Mobile Image Search not recognized #2569

sgiehl opened this issue Jul 17, 2011 · 4 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
1.6

Comments

@sgiehl
Copy link
Member

sgiehl commented Jul 17, 2011

The mobile image search of google is not detected at all:

http://www.google.com/m/imgres?gl=fr&source=mog&client=ms-android-google&q=piwik&hl=fr&start=0&site=images&imgid=ANd9GcQxUscuUydTOpon0arCcnJsjK4HF4CHQe1xB72QGlnC4GOYD3duGPPHtqFU&imgsz=139568&imgurl=http://piwik.org/wp-content/uploads/2008/11/piwik-e280ba-web-analytics-reports7.png&imgrefurl=http://fr.piwik.org/&ht=367&wd=622&tbnh=80&tbnw=136&ei=bgUiTvikOtPo8QPlgruUAw&ved=0CAkQ9QEwAA

Problem seems to be the special handling for google image search in core/Common.php:

if($searchEngineName === 'Google Images'
    || ($searchEngineName === 'Google' && strpos($referrerUrl, '/imgres') !== false) )
{
    $query = urldecode(trim(self::getParameterFromQueryString($query, 'prev')));
    $query = str_replace('&', '&', strstr($query, '?'));
    $searchEngineName = 'Google Images';
}

/imageres is in the url, but there is no prev parameter...
@anonymous-matomo-user
Copy link

Here is a patch I'm using to identify these searches as Google Images. Replace 1385-1391 block in Common.php (from trunk)

        if($searchEngineName === 'Google Images'
    || ($searchEngineName === 'Google' && strpos($referrerUrl, '/imgres') !== false) )
        {
            if(strpos($referrerUrl, '&prev=') !== false)
            {
                $query = urldecode(trim(self::getParameterFromQueryString($query, 'prev')));
                $query = str_replace('&', '&', strstr($query, '?'));
            }
        $searchEngineName = 'Google Images';
    }

@anonymous-matomo-user
Copy link

Attachment: Associated Patch
gi.diff

@anonymous-matomo-user
Copy link

The unit test patch for this is on the forum:
http://forum.piwik.org/read.php?2,80107

@robocoder
Copy link
Contributor

(In [5143]) fixes #2569, fixes #2616, refs #2652, adds Google Video

@sgiehl sgiehl added this to the 1.6 Piwik 1.6 milestone Jul 8, 2014
This was referenced Sep 10, 2011
Closed
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
1.6
Development

No branches or pull requests
3 participants
@robocoder @sgiehl @anonymous-matomo-user