Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

piwik.js: Tracker Proxy doesn't support _paq.push( item1, item2, ... ) #2573

Closed
robocoder opened this issue Jul 18, 2011 · 2 comments
Closed
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@robocoder
Copy link
Contributor

Initially, _paq is an array, and Array.push() allows for multiple items to be pushed onto the array. However, once piwik.js is loaded, _paq is converted to a proxy object, and push() expects only a single item.

While our examples never showed pushing multiple items, we should continue to hide the implementation details of the proxy.

@robocoder
Copy link
Contributor Author

(In [5031]) fixes #2573

@mattab
Copy link
Member

mattab commented Jul 19, 2011

Very nice to fix this inconsistency!

@robocoder robocoder added this to the 1.6 Piwik 1.6 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

2 participants