Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assume_secure_protocol is not checked in View #2594

Closed
anonymous-matomo-user opened this issue Jul 27, 2011 · 2 comments
Closed

assume_secure_protocol is not checked in View #2594

anonymous-matomo-user opened this issue Jul 27, 2011 · 2 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@anonymous-matomo-user
Copy link

When running behind a reverse proxy with ssl, the config variable assume_secure_protocol is set to 1. This seems to set the url protocol (https) correctly everyplace except in the dashboard javascript. The piwik.piwik_url variable in the global js still has "http" for the protocol. To fix this I added the Piwik::isHttps check to core/View.php after $this->piwikUrl is set (line 45):

if(Piwik::isHttps()
&& strpos($this->piwikUrl, 'http://') === 0)
{
$this->piwikUrl = str_replace('http://', 'https://', $this->piwikUrl);
}

@robocoder
Copy link
Contributor

(In [5068]) * fixes #2594 - apply gator's patch

  • currentUrlWithoutFilename is redundant; consolidate with piwikUrl

@robocoder
Copy link
Contributor

(In [5070]) fixes #2606, refs #2594

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

2 participants