Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Piwik_Url: getCurrentSchema() should check assume_secure_protocol #2606

Closed
robocoder opened this issue Aug 2, 2011 · 5 comments
Closed

Piwik_Url: getCurrentSchema() should check assume_secure_protocol #2606

robocoder opened this issue Aug 2, 2011 · 5 comments
Assignees
@robocoder
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
1.6

Comments

@robocoder
Copy link
Contributor

#2594 was nagging at me all night.

I did a review of the code base, and there doesn't appear to be a reason why getCurrentSchema() couldn't return https when assume_secure_protocol = 1.

This would eliminate the special cases in the code. So, let's refactor and clean this up.
@robocoder
Copy link
Contributor Author

(In [5070]) fixes #2606, refs #2594

@mattab
Copy link
Member

mattab commented Aug 10, 2011

thanks for all the technical debt fixes.

Regarding this change,

  • can you please confirm that you tested to load https://server/piwik and all files were loading fine over https without triggering browser warning?
  • how much effort (hours) would it take to have a webtest testing to load the https version of piwik and verify that all links / ressources are https ?

thx

@mattab
Copy link
Member

mattab commented Aug 16, 2011

reopening pending some QA questions above, vipsoft would you mind taking a quick look?

@robocoder
Copy link
Contributor Author

There's no warning if you have a valid certificate (or accepted a self-signed one).

Webtest: The main stumbling blocks are going to be the jetty/jenkins environment, and how to reliably test ajax requests and dynamic content. (The latter already causes sporadic test failures.)

@mattab
Copy link
Member

mattab commented Aug 16, 2011

thanks for confirming

@robocoder robocoder added this to the 1.6 Piwik 1.6 milestone Jul 8, 2014
@robocoder robocoder self-assigned this Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robocoder robocoder

Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
1.6
Development

No branches or pull requests
2 participants
@mattab @robocoder