Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#2631 closed Bug (fixed)

trunk: Hexadecimal encoded URLs don't decoded

Reported by: thoti Owned by: vipsoft
Priority: normal Milestone: 1.6 Piwik 1.6
Component: Core Keywords:
Cc: Sensitive: no

Description

Links in a website of the form <a href="mailto:%69%6e%66%6f@%65%78%61%6d%70%6c%65.%63%6f%6d">info@…</a> don't get decoded. In the user-log they are shown still encoded.
They should get decoded (normalized) befor they are saved into the database.

Attachments (1)

Not_urldecoded_URL.png (28.7 KB) - added by thoti 3 years ago.
Example of the user-log with an undecoded URL

Download all attachments as: .zip

Change History (11)

Changed 3 years ago by thoti

Example of the user-log with an undecoded URL

comment:1 Changed 3 years ago by vipsoft (robocoder)

  • Keywords urldecode hex url mailto link href removed
  • Milestone set to 1.6 Piwik 1.6
  • Owner set to vipsoft

comment:2 Changed 3 years ago by vipsoft (robocoder)

  • Resolution set to fixed
  • Status changed from new to closed

(In [5121]) fixes #2631

comment:4 Changed 3 years ago by matt (mattab)

  • Resolution fixed deleted
  • Status changed from closed to reopened

The changeset decodes the referer, but the bug report mentions the "link" parameter. Testing with proposed example I still see in the GET request: link=mailto:%69%6e%66%6f@%65%78%61%6d%70%6c%65.%63%6f%6d

comment:5 Changed 3 years ago by vipsoft (robocoder)

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [5142]) fixes #2631

comment:6 Changed 3 years ago by matt (mattab)

(In [5324]) Revert [5121] causing buggy referrer keywords when accents/umlauts etc. as per report in http://forum.piwik.org/read.php?2,81827 Refs #2631

comment:7 Changed 3 years ago by vipsoft (robocoder)

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:8 Changed 3 years ago by matt (mattab)

I think this bug is still fixed since I only removed the unescape() of the referrer, this bug is about the click tracking?

comment:9 Changed 3 years ago by vipsoft (robocoder)

  • Resolution set to fixed
  • Status changed from reopened to closed

ah; ok

comment:10 Changed 3 years ago by vipsoft (robocoder)

  • Summary changed from Hexadecimal encoded URLs don't decoded to trunk: Hexadecimal encoded URLs don't decoded
Note: See TracTickets for help on using tickets.