Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trunk: Hexadecimal encoded URLs don't decoded #2631

Closed
anonymous-matomo-user opened this issue Aug 16, 2011 · 8 comments
Closed

trunk: Hexadecimal encoded URLs don't decoded #2631

anonymous-matomo-user opened this issue Aug 16, 2011 · 8 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@anonymous-matomo-user
Copy link

Links in a website of the form <a href="mailto:%69%6e%66%6f@%65%78%61%6d%70%6c%65.%63%6f%6d">info@example.com</a> don't get decoded. In the user-log they are shown still encoded.
They should get decoded (normalized) befor they are saved into the database.

@anonymous-matomo-user
Copy link
Author

Attachment: Example of the user-log with an undecoded URL
Not_urldecoded_URL.png

@robocoder
Copy link
Contributor

(In [5121]) fixes #2631

@robocoder
Copy link
Contributor

(In [5122]) fixes #2631

@mattab
Copy link
Member

mattab commented Sep 6, 2011

The changeset decodes the referer, but the bug report mentions the "link" parameter. Testing with proposed example I still see in the GET request: link=mailto:%69%6e%66%6f@%65%78%61%6d%70%6c%65.%63%6f%6d

@robocoder
Copy link
Contributor

(In [5142]) fixes #2631

@mattab
Copy link
Member

mattab commented Oct 18, 2011

(In [Revert 5121) causing buggy referrer keywords when accents/umlauts etc. as per report in http://forum.piwik.org/read.php?2,81827 Refs #2631

@mattab
Copy link
Member

mattab commented Oct 18, 2011

I think this bug is still fixed since I only removed the unescape() of the referrer, this bug is about the click tracking?

@robocoder
Copy link
Contributor

ah; ok

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

3 participants