Opened 3 years ago

Closed 20 months ago

Last modified 20 months ago

#2654 closed New feature (fixed)

Piwik Mobile to display Custom Variables values when a Custom var name is clicked

Reported by: matt Owned by: tsteur
Priority: major Milestone: Piwik Mobile Client
Component: Core Keywords:
Cc: Sensitive: no

Description (last modified by matt)

When clicking on a row (Custom var name) Piwik mobile would show a subtable with values (custom var values)
Requested in: http://forum.piwik.org/read.php?2,76375

Piwik Mobile requirements:

  • Is Piwik Mobile already able to display a subtable in the same screen?
  • Or would Piwik Mobile reload the screen to display only the Custom var values after clicking on a Custom var name? In this case, the "swipe / back" gesture would come back to the previous "Custom variable names" report.

Both solutions would be fine IMO... whatever is easiest/best could be done?

There are also "Piwik core" requirements to make this feature work:

  • Piwik Metadata API also returns which API to call when a row is clicked eg. CustomVariables.getCustomVariablesValuesFromNameId
  • Piwik metadata should support the API call CustomVariables.getCustomVariablesValuesFromNameId currently unsupported

Then piwik mobile would call metadata API for this API method which would return the whole report for the row clicked, as a standard Piwik report

Any feedback please post a comment!

Attachments (3)

Screenshot_229.png (31.0 KB) - added by tsteur 20 months ago.
Screenshot_230.png (24.8 KB) - added by tsteur 20 months ago.
Screenshot_232.png (34.6 KB) - added by tsteur 20 months ago.

Download all attachments as: .zip

Change History (32)

comment:1 Changed 2 years ago by tsteur

  • Description modified (diff)

I'd like to work on this feature. Also want to display a subtable for pages. For example clicking on '/support' opens '/support/contact', '/support/faq', ...

Therefore the api has to return which API to call when a row is clicked (as you mentioned) and maybe which parameter to pass.

comment:2 Changed 2 years ago by matt (mattab)

  • Description modified (diff)

see also #2742

comment:3 Changed 22 months ago by tsteur

  • Owner set to tsteur
  • Status changed from new to assigned

comment:4 Changed 22 months ago by tsteur

(In [6500]) refs #2654 refactored TableView and StatisticList. Also fixed some possible memory leaks

comment:5 Changed 22 months ago by tsteur

(In [6501]) refs #2654 prevent cleanup from list of reports window on iPad

comment:6 Changed 22 months ago by tsteur

  • Owner tsteur deleted
  • Status changed from assigned to new

comment:7 Changed 22 months ago by matt (mattab)

  • Milestone changed from Piwik Mobile Client to 1.8.x - Piwik 1.8.x
  • Priority changed from low to major

Moving to Piwik core so that we hopefully get going in the next 2 months on this :)

comment:8 Changed 21 months ago by matt (mattab)

  • Owner set to capedfuzz

comment:9 Changed 20 months ago by matt (mattab)

  • Milestone changed from 1.8.x - Piwik 1.8.x to Piwik Mobile Client
  • Owner changed from capedfuzz to tsteur

Thanks Benaka for your work on this and unblocking Thomas to continue improving Piwik Mobile, to display the very useful sub-table analytics data!

comment:10 Changed 20 months ago by tsteur

  • Status changed from new to assigned

comment:11 Changed 20 months ago by tsteur

(In [6880]) refs #2654 a first working version. still have to do lots of tests and detect possible memory leaks

comment:12 Changed 20 months ago by tsteur

(In [6881]) refs #2654 make sure cleanup continues even if there are errors

comment:13 Changed 20 months ago by tsteur

(In [6889]) refs #2654 make sure tableview eventlistener will be added only once

comment:14 Changed 20 months ago by tsteur

(In [6896]) refs #2654 make sure the label has always the same left position even if hasChild is true

comment:15 Changed 20 months ago by tsteur

(In [6898]) refs #2654 display subtables only if Piwik version is 1.8.4 or newer

comment:16 Changed 20 months ago by tsteur

(In [6903]) refs #2654 request piwik version max once a day

comment:17 Changed 20 months ago by tsteur

(In [6904]) refs #2654 do not overwrite an already existing version if something went wrong during request

comment:18 Changed 20 months ago by tsteur

(In [6906]) refs #2654 track piwik version as a page custom variable

comment:19 Changed 20 months ago by tsteur

  • Resolution set to fixed
  • Status changed from assigned to closed

comment:20 Changed 20 months ago by matt (mattab)

Excellent !! Users will love this... such an important feature and will expose critical data in the mobile app. Kuddos Thomas and Benaka :)

Some questions;

  • do you leave the parent table visible and display the subtable - or do you only display the subtable in a new window?
  • Thomas would you mind posting some screenshots of the feature?

comment:21 Changed 20 months ago by tsteur

Sure! I'll add some screenshots. You'll notice that the screenshot of the subtable don't display a "websites selector". This is because the subtable report won't exist in another website. Therefore it makes no sense to be able to switch the website there. It would result in an error.

I don't leave the parent table visible but instead open a new window to display the subtable. Everything else would be really tricky / hard to implement with Titanium. In addition it has some advantages to do it this way. Users can view the graph, change date/metric, better readable, if a subtable had subtables it would be possible to open even those :) I think it's also more "mobile-like"

Changed 20 months ago by tsteur

Changed 20 months ago by tsteur

comment:22 Changed 20 months ago by tsteur

(In [6915]) refs #2654 make sure piwik server version will be updated if a user changes an account

comment:23 Changed 20 months ago by matt (mattab)

Good, on the "Back" button when viewing the subtable, could you write the
name of the parent report ie. "Custom Variables" instead of "Back" on the
button?

comment:24 Changed 20 months ago by tsteur

I had wrote the name of the parent report ie "Custom Variables" instead of "Back" in a first version and then replaced it with "Back". There is often not enough space on a mobile device. Shall I do it though? It definitely makes sense on the iPad, not sure for iPhone. Maybe it is indeed better to have a shortened title instead of only "Back". I'll attach another screenshot.

Changed 20 months ago by tsteur

comment:25 Changed 20 months ago by tsteur

(In [6919]) refs #2654 display name of parent report instead of only Back

comment:26 Changed 20 months ago by tsteur

I thought about it... I think it's definitely better to write the name of the parent report instead of "Back".

comment:27 Changed 20 months ago by matt (mattab)

Definitely, however, can you please split 2 words on 2 lines as it would look much better and use less width!

comment:28 Changed 20 months ago by tsteur

It's not possible to split text into multiple lines in header. Multiple lines are not supported by Titanium there and I'm pretty sure also not by iOS. It's also not possible to specify the width or height of the back button.

comment:29 Changed 20 months ago by matt (mattab)

Ok thanks for confirming - it's nice as it is.

Note: See TracTickets for help on using tickets.