Opened 3 years ago

Closed 3 years ago

#2662 closed Bug (fixed)

Actions.getPageTitle and getPageUrl should work like other API methods with date=last30

Reported by: matt Owned by:
Priority: normal Milestone: 1.6 Piwik 1.6
Component: Core Keywords:
Cc: Sensitive: no

Description

Currently it returns an error: http://demo.piwik.org/?module=API&method=Actions.getPageTitle&idSite=7&period=day&date=last30&format=html&token_auth=anonymous&pageName=Piwik%20Forums

We should patch the code so that the datatable accept to work with date=last30

Change History (4)

comment:1 Changed 3 years ago by EZdesign (BeezyT)

(In [5172]) Refs #2662 Actions.get* for date range

comment:2 Changed 3 years ago by matt (mattab)

Code review:

  • excellent work!
  • test: all the last30 for getPageUrl etc. only had 0 visit days. Would you be able to add a test that shows results with data for the queried dates?

comment:3 Changed 3 years ago by matt (mattab)

Note: for the tests, it will be pretty easy to add them, see example in this commit: http://dev.piwik.org/trac/changeset/5197#file2

comment:4 Changed 3 years ago by matt (mattab)

  • Resolution set to fixed
  • Status changed from new to closed

(In [5235]) Fixes #2667

  • Stop aggregating visits for Custom variables of scope "page"
    • still OK for scope "visit" since there is supposed to be one custom var value per custom variable name for a given visit
  • Now we always display the Actions columns so that these rows with no visit still show the number of Actions
  • cleaned up from custom var output report, removed some "price_viewed" column left out

UI Change (future FAQ maybe...)

  • When there is a "Visits" column for the Custom Variable report with a value of "-" (hyphen) then it means this custom variable was used with scope=page.

Fixes #2662

  • Added integration tests testing getPageUrl with multiple periods and websites
  • fixed a bug when idSite=all or 1,2,3
Note: See TracTickets for help on using tickets.