Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Middle click (open in a new tab) should work as expected for menus, website selector #2663

Closed
mattab opened this issue Sep 16, 2011 · 8 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Sep 16, 2011

Usability improvement: the middle click button (open in new tab) should work nicely on the website selector, and the main menu.

  • Currently, middle click on website selector opens in a new table for example "javascript:broadcast.propagateNewPage(%20'idSite=13');"
  • Middle click on the menu opens the dashboard in a new tab, instead of clicked menu

I'm not sure the best way to handle this, hopefully we can refactor the javascript code to generate the URL and have it returned onclick?

@sgiehl
Copy link
Member

sgiehl commented Sep 16, 2011

(In [5173]) fixes #2663 middle click for open in new tab didn't work because of incorrect href attributes and javascript events bound with jquery. now working in most browsers except of IE 9 (seems to be a known bug)

@mattab
Copy link
Member Author

mattab commented Sep 17, 2011

Reopening for small feedback: when opening "website selector" in new tab, can it also restore 'date' 'period' parameters? I'm thinking use case: website 1 is decreasing for this custom range, check other websites in a new tab for same pattern .

thanks!

@sgiehl
Copy link
Member

sgiehl commented Sep 17, 2011

Should it also restore the current view? atm it always switches back to dashboard...

@sgiehl
Copy link
Member

sgiehl commented Sep 17, 2011

(In [5174]) refs #2663 fixed urls in site selection, now date und period is restored on middle click

@mattab
Copy link
Member Author

mattab commented Sep 17, 2011

Agreed, should set the same view again, I think most users will click on other views and it is less tiring for the brain :)

@sgiehl
Copy link
Member

sgiehl commented Sep 17, 2011

(In [5175]) refs #2663 update links in site selection with current view, date and period params

@mattab
Copy link
Member Author

mattab commented Sep 21, 2011

Reopening as I found a bug. When visiting the API page: http://localhost/trunk/index.php?module=API&action=listAllAPI&period=week&date=today&idSite=3

a left click on the website selector now reloads the page AND shows the selector, instead it should not reload the page but only show the selector as before. I thought the regression was maybe linked to these changes?

@sgiehl
Copy link
Member

sgiehl commented Sep 21, 2011

(In [5201]) fixes #2663 fixes problem on api page

@mattab mattab added this to the 1.6 Piwik 1.6 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

No branches or pull requests

2 participants