Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "visits" from Custom Variables names report since it is incorrect #2667

Closed
mattab opened this issue Sep 17, 2011 · 1 comment
Closed
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Sep 17, 2011

Custom Variables are aggregated by 2 dimensions (name, value) therefore the count of visits for the first dimension: name, is not correct (since it sums visits for value1 and value2).

Reproduce:

  • Track customVariablePageValue1 = A and customVariablePageValue1 = B (two actions)
  • The CustomVariables report shows one visit for value A and one for value B. But the aggregated value of visits is two (which should be one).
    -> Two visits instead of one.
@mattab
Copy link
Member Author

mattab commented Sep 27, 2011

(In [5235]) Fixes #2667

  • Stop aggregating visits for Custom variables of scope "page"
    • still OK for scope "visit" since there is supposed to be one custom var value per custom variable name for a given visit
  • Now we always display the Actions columns so that these rows with no visit still show the number of Actions
  • cleaned up from custom var output report, removed some "price_viewed" column left out

UI Change (future FAQ maybe...)

  • When there is a "Visits" column for the Custom Variable report with a value of "-" (hyphen) then it means this custom variable was used with scope=page.

Fixes #2662

  • Added integration tests testing getPageUrl with multiple periods and websites
  • fixed a bug when idSite=all or 1,2,3

@mattab mattab added this to the 1.6 Piwik 1.6 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

1 participant