Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow JSONP parameter name to be either "callback" or " jsoncallback" #2679

Closed
anonymous-matomo-user opened this issue Sep 23, 2011 · 5 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@anonymous-matomo-user
Copy link

Why do we require "jsoncallback=?" and not just the "callback=?" that jQuery defaults to? It would be a lot easier on new developers if their jQuery calls just worked instead of having to append an extra hash.

@robocoder
Copy link
Contributor

JSONP doesn't dictate the parameter name. But I suspect when jsonp support was added, the parameter name didn't default to "callback". (Today, this appears to de facto with jquery, dojo, and extjs.)

I'm guessing we would have to make this configureable since it is a potential compat buster.

@robocoder
Copy link
Contributor

(In [5216]) fixes #2679 - use de facto standard "callback" for the JSONP callback parameter name

@mattab
Copy link
Member

mattab commented Sep 25, 2011

changeset not BC, we should read both jsoncallback and callback parameter for BC

@robocoder
Copy link
Contributor

(In [5221]) fixes #2679 - fallback to jsoncallback (BC)

@robocoder
Copy link
Contributor

(In [5222]) refs #2679

@anonymous-matomo-user anonymous-matomo-user added this to the 1.6 Piwik 1.6 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

3 participants