Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UserAgentParser: should report Android's browser as Safari #2694

Closed
anonymous-matomo-user opened this issue Oct 8, 2011 · 7 comments
Closed
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@anonymous-matomo-user
Copy link

XXX.XXX.XXX.XXX - - +0200 "GET /dummypage.html HTTP/1.1" 200 2843 "http://www.example.org/" "Mozilla/5.0 (Linux; U; Android 2.2; de-de; HTC Desire 2.33.161.2 Build/FRF91) AppleWebKit/533.1 (KHTML, like Gecko) Version/4.0 Mobile Safari/533.1"

will be detected as "Android 4.0 with plugins flash enabled"

@robocoder
Copy link
Contributor

If you're looking at the Browser report, it's reporting the browser version. Version/4 is explicitly set in the user agent so it is customary to use that value. Using the Android OS version is wrong imho. Maybe we should just report it as Safari or Mobile Safari?

@robocoder
Copy link
Contributor

A patch for Chrome on Android reportedly landed this past week, so we'll report as Safari to avoid later confusion.

@robocoder
Copy link
Contributor

(In [5272]) fixes #2694 - detect current Android browser as Safari (like iPad/iPhone/iPod); added a ficticious mobile Chrome user agent (commented out for now, but it works)

@robocoder
Copy link
Contributor

(In [5273]) refs #2694 - remove remnants of "Android" browser (obsolete)

@robocoder
Copy link
Contributor

FYI if/when mobile Chrome comes to Android, it'll be reported as Chrome

@anonymous-matomo-user
Copy link
Author

This bug is not fixed, the problem still persists in version 1.12.

@mattab
Copy link
Member

mattab commented Aug 9, 2013

What is the bug exactly? what user agent, what is behavior VS what do you expect? create a new ticket

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

3 participants