Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV Export of VisitFrequency.get is broken when there are conversions for only a subset of periods #2765

Closed
timo-bes opened this issue Nov 9, 2011 · 3 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. duplicate For issues that already existed in our issue tracker and were reported previously.
Milestone

Comments

@timo-bes
Copy link
Member

timo-bes commented Nov 9, 2011

Reproduce:

http://demo.piwik.org/?module=API&method=VisitFrequency.get&format=CSV&idSite=7&period=day&date=2011-03-20,2011-04-20&token_auth=anonymous

Phenomenon:

Some rows have fewer columns and the values to the right of the missing ones move up. As a result, they are placed in the wrong column.

Hints:

  • It looks like nb_visits_converted_returning is missing when the value is 0. In my local database, sum_visit_length_returning is even missing for one day. This day has bounce_rate_returning=100%, so sum_visit_length_returning would be 0 in this case as well.
  • The columns are already missing in the DataTable ($this->table) in Piwik_DataTable_Renderer_Csv.
  • It only happens when date=...,...: Take a look at the report for 2011-04-04,2011-04-05. 2011-04-04 is missing nb_visits_converted_returning. When you look at the report for only 2011-04-04, it has nb_visits_converted_returning=0, i.e. the column is not missing.
@mattab
Copy link
Member

mattab commented Nov 11, 2011

IMO VisitsFrequency should be deprecated in favor of using the segmentation API. See #2419 and #539

But hopefully this bug can be fixed too.

@timo-bes
Copy link
Member Author

I just experienced this bug again. In Referers.getRefererType, when there are goals for some days and not for others, some rows are wider than others.

When we combine the CSVs of the subperiods, we have to keep track of which columns exist und fill the rows that don't have some columns with empty values.

@mattab
Copy link
Member

mattab commented May 28, 2012

AFAIK it looks fixed, see: #3055

Please check and post a comment if not fixed!

@timo-bes timo-bes added this to the Piwik 1.8 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. duplicate For issues that already existed in our issue tracker and were reported previously.
Projects
None yet
Development

No branches or pull requests

2 participants