Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create_function mem leaks #2771

Closed
robocoder opened this issue Nov 11, 2011 · 6 comments
Closed

create_function mem leaks #2771

robocoder opened this issue Nov 11, 2011 · 6 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Milestone

Comments

@robocoder
Copy link
Contributor

replace where possible with static methods

mem leaks are worse in 5.2

@robocoder
Copy link
Contributor Author

(In [5446]) fixes #2771 - will revert this when the minimum requirements is php 5.3 and we can use anonymous functions sigh

@robocoder
Copy link
Contributor Author

(In [5448]) refs #2771

@robocoder
Copy link
Contributor Author

pclzip unit test says something's still broken

I'll fix this in the morning -- can't keep my eyes open right now

@robocoder
Copy link
Contributor Author

(In [5454]) refs #2771 - reverting patch

@robocoder
Copy link
Contributor Author

Pclzip can't use call_user_func because it passes parameters by refererence

not seeing significant memory gains (could be my test data isn't big/varied enough); so, weighing code ugliness vs memleaks ... I'm reverting the patch

@mattab
Copy link
Member

mattab commented Nov 19, 2011

Thanks for patch and I +1 for revert!

@robocoder robocoder added this to the 1.7 Piwik 1.7 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Development

No branches or pull requests

2 participants