Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: duplicated visits are created when IP is different every page view #2785

Closed
mattab opened this issue Nov 16, 2011 · 3 comments
Closed
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Nov 16, 2011

This is definitely a regression introduced some time in the last few months.

When the visitor IP is changing, AND the visitor supports the id cookie, we should properly detect the unique visitor. Instead it seems that in some cases there is a new visit created on every page view. See attached screenshot.

@mattab
Copy link
Member Author

mattab commented Nov 16, 2011

Attachment:
multiple visits.png

@mattab
Copy link
Member Author

mattab commented Dec 7, 2011

(In [5530]) Refs #2785 - Changing test to highlight the problem, the build should fail

@mattab
Copy link
Member Author

mattab commented Dec 7, 2011

(In [5531]) Fixes #2785

  • Finally getting the code right after 4 years...! the SELECT will now select several rows and order by priority based on the matched attribute, but not on intranet, and only when there was a visitor id found in the 1st party/3rd cookie, or via setForcedVisitorId()
  • Fixes notices when invalid ID supplied/ When provider plugin disabled

@mattab mattab added this to the 1.7 Piwik 1.7 milestone Jul 8, 2014
@mattab mattab self-assigned this Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

No branches or pull requests

1 participant