Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#2785 closed Bug (fixed)

Regression: duplicated visits are created when IP is different every page view

Reported by: matt Owned by: matt
Priority: major Milestone: 1.7 Piwik 1.7
Component: Core Keywords:
Cc: Sensitive: no

Description

This is definitely a regression introduced some time in the last few months.

When the visitor IP is changing, AND the visitor supports the id cookie, we should properly detect the unique visitor. Instead it seems that in some cases there is a new visit created on every page view. See attached screenshot.

Attachments (1)

multiple visits.png (32.1 KB) - added by matt 2 years ago.

Download all attachments as: .zip

Change History (6)

Changed 2 years ago by matt (mattab)

comment:1 Changed 2 years ago by matt (mattab)

  • Priority changed from major to critical

comment:2 Changed 2 years ago by matt (mattab)

  • Owner set to matt
  • Summary changed from Duplicated visits when IP is changed on every page view to Regression: duplicated visits are created when IP is different every page view

comment:3 Changed 2 years ago by matt (mattab)

(In [5530]) Refs #2785 - Changing test to highlight the problem, the build should fail

comment:4 Changed 2 years ago by matt (mattab)

  • Resolution set to fixed
  • Status changed from new to closed

(In [5531]) Fixes #2785

  • Finally getting the code right after 4 years...! the SELECT will now select several rows and order by priority based on the matched attribute, but not on intranet, and only when there was a visitor id found in the 1st party/3rd cookie, or via setForcedVisitorId()
  • Fixes notices when invalid ID supplied/ When provider plugin disabled

comment:5 Changed 2 years ago by matt (mattab)

  • Priority changed from critical to major
Note: See TracTickets for help on using tickets.