Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#2806 closed Bug (fixed)

PHP 5.4.0RC3 compatibility

Reported by: vipsoft Owned by:
Priority: normal Milestone: 1.7 Piwik 1.7
Component: Core Keywords:
Cc: Sensitive: no

Description (last modified by vipsoft)

Tested with PHP 5.4.0 RC3

Change History (20)

comment:3 Changed 2 years ago by vipsoft (robocoder)

Notices to fix:

Strict Standards: Declaration of MockPiwik_Access::checkUserHasAdminAccess() should be compatible with Piwik_Access::checkUserHasAdminAccess($idSites)
Strict Standards: Declaration of MockPiwik_Access::checkUserHasViewAccess() should be compatible with Piwik_Access::checkUserHasViewAccess($idSites)
Strict Standards: Declaration of MockPiwik_Access::reloadAccess() should be compatible with Piwik_Access::reloadAccess(Piwik_Auth $auth = NULL)
Strict Standards: Declaration of MockPiwik_Access::setSuperUser() should be compatible with Piwik_Access::setSuperUser($bool = true)
Strict Standards: Declaration of Piwik_DataTable_Renderer_Csv::renderHeader() should be compatible with Piwik_DataTable_Renderer::renderHeader()
Strict Standards: Declaration of Piwik_Period_Year::toString() should be compatible with Piwik_Period::toString($format = 'Y-m-d')
Strict Standards: Non-static method Mock::generate() should not be called statically, assuming $this from incompatible context
Strict Standards: Non-static method Mock::generatePartial() should not be called statically, assuming $this from incompatible context
Strict Standards: Non-static method SimpleErrorQueue::getSeverityAsString() should not be called statically
Strict Standards: Non-static method SimpleReporter::inCli() should not be called statically
Strict Standards: Non-static method SimpleTest::getContext() should not be called statically
Strict Standards: Non-static method SimpleTest::getContext() should not be called statically, assuming $this from incompatible context
Strict Standards: Non-static method SimpleTest::getMockBaseClass() should not be called statically, assuming $this from incompatible context
Strict Standards: Non-static method SimpleTest::ignore() should not be called statically, assuming $this from incompatible context
Strict Standards: Non-static method SimpleTest::ignoreParentsIfIgnored() should not be called statically, assuming $this from incompatible context
Strict Standards: Non-static method SimpleTest::isIgnored() should not be called statically, assuming $this from incompatible context
Strict Standards: Non-static method SimpleTestCompatibility::isA() should not be called statically, assuming $this from incompatible context
Strict Standards: Non-static method TestSuite::getBaseTestCase() should not be called statically, assuming $this from incompatible context

comment:4 Changed 2 years ago by vipsoft (robocoder)

(In [5506]) refs #2806 - refactor fix for Declaration of Piwik_Period_Year::toString() should be compatible with Piwik_Period::toString($format = 'Y-m-d')

comment:5 Changed 2 years ago by vipsoft (robocoder)

(In [5507]) refs #2806 - minimal changes to simpletest to accommodate php 5.4.0rc2 incompatibilities

comment:6 Changed 2 years ago by vipsoft (robocoder)

  • Resolution set to fixed
  • Status changed from new to closed

(In [5508]) fixes #2806, refs #2809 - quick fix

comment:7 Changed 2 years ago by vipsoft (robocoder)

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:8 Changed 2 years ago by vipsoft (robocoder)

Sorry that was just the first batch -- there are additional notices to be addressed. =P

comment:9 Changed 2 years ago by vipsoft (robocoder)

(In [5511]) refs #2806 - not sure why but r5506 introduced a regression; reverting and adding a dummy parameter to satisfy php 5.4

comment:10 Changed 2 years ago by vipsoft (robocoder)

(In [5512]) refs #2806 - silent array to string conversion now emits notice

11 Nov 2011, PHP 5.4.0 RC1
- General improvements:
  . Changed silent conversion of array to string to produce a notice. (Patrick)

comment:12 Changed 2 years ago by vipsoft (robocoder)

Sorry, I had a dyslexic morning and ref'd the wrong ticket in my commits.

(In [5513]) refs #2806 - Non-static method Piwik_Tracker_Db::isProfilingEnabled() should not be called statically

(In [5514]) refs #2806 - Unexpected PHP error [Array to string conversion] severity

(In [5515]) refs #2806 - Unexpected PHP error [Array to string conversion] and Only variables should be passed by reference

(In [5516]) refs #2806

(In [5517]) refs #2806 - revert regression in [5515]

comment:15 Changed 2 years ago by vipsoft (robocoder)

(In [5526]) refs #2806 - fix message

comment:16 Changed 2 years ago by vipsoft (robocoder)

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [5527]) fixes #2806 - finally, remove this webtest (Piwik 1.0 is not 5.4.0 compatible); we still test the install/update from 1.1.1 (which is about a year old now)

comment:17 Changed 2 years ago by vipsoft (robocoder)

  • Summary changed from PHP 5.4.0 compatibility to PHP 5.4.0RC2 compatibility

comment:18 Changed 2 years ago by vipsoft (robocoder)

(In [5538]) refs #2806 - these were caught by php -l

comment:19 Changed 2 years ago by vipsoft (robocoder)

(In [5539]) refs #2806 - make it clearer that this parameter is ignored

comment:20 Changed 2 years ago by vipsoft (robocoder)

  • Description modified (diff)
  • Summary changed from PHP 5.4.0RC2 compatibility to PHP 5.4.0RC3 compatibility
Note: See TracTickets for help on using tickets.