Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trunk DataTable/Renderer/Csv.php - incompatible renderHeader() #2809

Closed
robocoder opened this issue Dec 2, 2011 · 3 comments
Closed

trunk DataTable/Renderer/Csv.php - incompatible renderHeader() #2809

robocoder opened this issue Dec 2, 2011 · 3 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@robocoder
Copy link
Contributor

In PHP 5.4, the new method signature (where we now pass $this) is incompatible with the parent class, causing a notice to be emitted when E_STRICT is set.

The quick fix is to roll-back this aspect of [5463].

@robocoder
Copy link
Contributor Author

(In [5508]) fixes #2806, refs #2809 - quick fix

@timo-bes
Copy link
Member

timo-bes commented Dec 6, 2011

(In [5529]) fixes #2809, refs #2714: making signature of Piwik_DataTable_Renderer::renderHeader() compatible across subclasses

@robocoder
Copy link
Contributor Author

(In [5534]) refs #2809 - refactoring

@robocoder robocoder added this to the 1.7 Piwik 1.7 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

2 participants