Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Multi Sites plugin to follow Piwik plugin conventions #2810

Closed
diosmosis opened this issue Dec 2, 2011 · 3 comments
Closed

Refactor Multi Sites plugin to follow Piwik plugin conventions #2810

diosmosis opened this issue Dec 2, 2011 · 3 comments
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone

Comments

@diosmosis
Copy link
Member

The Multi Sites plugin currently works fine, but does not follow Piwik plugin conventions. It does not expose an API class and uses other APIs when it could access data directly from Archive types. Refactoring the plugin will speed it up, clarify the code and allow it to be tested.

@diosmosis
Copy link
Member Author

(In [5626]) Fixes #2810. Refactored MultiSites plugin:

  • Created MultiSites API w/ getAll method that gets visit/action/revenue & related evolution data for all sites.
  • Modified MultiSites Controller to use aforementioned API.
  • Fixed bug I introduced in integration tests, method doTest_TwoVisitors_twoWebsites_differentDays shouldn't allow tests to skip the API.getProcessedReport test.
  • Added mergeChildren & related unit test to Piwik_DataTable_Array.
  • Added static methods to Piwik_Site to get site data using an ID. Using it avoids having to create a new Piwik_Site instance.
  • Modified ColumnCallbackAddColumnQuotient so it can be better extended and so it's possible to avoid processing rows if desired.

@diosmosis
Copy link
Member Author

(In [5627]) Refs #2810, bug in last commit.

@mattab
Copy link
Member

mattab commented Feb 2, 2012

(In [5740]) Fixes #2600

  • Note: it was already working before, kuddos cappedfuzz for your work!! Refs Refactor Multi Sites plugin to follow Piwik plugin conventions #2810
  • possible to add All websites dashboard to the PDF/HTML report
  • Only websites with data are displayed. This might raise support questions "Why is website not displayed in All websites in PDF report..." -> should we display all websites including those with 0 visits?
  • Adds sort by visit DESC to ensure data is displayed by visits sorted in the pdf report

@diosmosis diosmosis added this to the 1.x - Piwik 1.x milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

No branches or pull requests

2 participants