Opened 2 years ago

Closed 2 years ago

#2824 closed Bug (fixed)

Clean-up Windows Phone and Windows Mobile version detection

Reported by: matt Owned by:
Priority: normal Milestone: 1.7 Piwik 1.7
Component: Core Keywords:
Cc: Sensitive: no

Description

See forum post: http://forum.piwik.org/read.php?3,83981

Let's check that the parsing algorithm will automatically detect further Windows Phone X updates in user agents.

Attachments (1)

os.png (10.6 KB) - added by SteveG 2 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 2 years ago by vipsoft (robocoder)

OS detection algorithm is different from the browser detection algorithm.

It's not really future-proofable, eg win 3.1, win 95x, win 3.51, win nt4, win 2k, win xp, win vista, win 7 are derived from the product names.

comment:2 Changed 2 years ago by matt (mattab)

Thanks for the details, no problem if it's not future proof.

comment:3 Changed 2 years ago by vipsoft (robocoder)

(In [5672]) refs #2824 - add placeholders for other Windows Phone and Windows Mobile versions (past & future); Windows operating systems are the only ones we identify by version ... why? also, Windows Phone market share is reportedly dropping; maybe we should drop the version number?

comment:4 Changed 2 years ago by vipsoft (robocoder)

  • Summary changed from Windows Phone 7.5 not detected to Clean-up Windows Phone and Windows Mobile version detection

comment:5 Changed 2 years ago by vipsoft (robocoder)

  • Resolution set to fixed
  • Status changed from new to closed

(In [5673]) fixes #2824

comment:6 Changed 2 years ago by SteveG (sgiehl)

Shouldn't we leave the old definitions and icons for already tracked data and only remove the detection?

Now already tracked data isn't displayed correct anymore after an update...

comment:7 Changed 2 years ago by vipsoft (robocoder)

We're only striving for API backward compatibility. Theoretically, users can delete archives and re-trigger archiving to reprocess reports.

comment:8 Changed 2 years ago by matt (mattab)

Steve can you post a screenshot of what you experience (broken BC?) ?

Windows Phone market share is reportedly dropping; maybe we should drop the version number?

Definitely a good idea to drop Windows phone OS version number, since we don't track these for other phones

comment:9 Changed 2 years ago by SteveG (sgiehl)

Well, as an automatic update doesn't delete the images we removed in svn, the only thing that might be displayed "incorrect" is an old "short" name for windows phone os. (see screenshot)

Changed 2 years ago by SteveG (sgiehl)

comment:10 Changed 2 years ago by matt (mattab)

  • Resolution fixed deleted
  • Status changed from closed to reopened

I saw it on the demo too, I think it makes sense to display a better name rather than raise questions (people will think this is a bug for sure)

Anthon do you think it's a quick fix?

Cheers!

comment:11 Changed 2 years ago by matt (mattab)

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [5748]) Fixes #2824

Restoring the display of Windows phones for backward compatibility.
Kuddos Anthon for fixing this ticket :)

Note: See TracTickets for help on using tickets.