Ticket #2824 (closed Bug: fixed)

Opened 5 months ago

Last modified 4 months ago

Clean-up Windows Phone and Windows Mobile version detection

Reported by: matt Owned by:
Priority: normal Milestone: 1.7 Piwik 1.7
Component: Core Keywords:
Cc: Sensitive: no

Description

See forum post:  http://forum.piwik.org/read.php?3,83981

Let's check that the parsing algorithm will automatically detect further Windows Phone X updates in user agents.

Attachments

os.png Download (10.6 KB) - added by SteveG 4 months ago.

Change History

Changed 5 months ago by vipsoft

OS detection algorithm is different from the browser detection algorithm.

It's not really future-proofable, eg win 3.1, win 95x, win 3.51, win nt4, win 2k, win xp, win vista, win 7 are derived from the product names.

Changed 5 months ago by matt

Thanks for the details, no problem if it's not future proof.

Changed 4 months ago by vipsoft

(In [5672]) refs #2824 - add placeholders for other Windows Phone and Windows Mobile versions (past & future); Windows operating systems are the only ones we identify by version ... why? also, Windows Phone market share is reportedly dropping; maybe we should drop the version number?

Changed 4 months ago by vipsoft

  • summary changed from Windows Phone 7.5 not detected to Clean-up Windows Phone and Windows Mobile version detection

Changed 4 months ago by vipsoft

  • status changed from new to closed
  • resolution set to fixed

(In [5673]) fixes #2824

Changed 4 months ago by SteveG

Shouldn't we leave the old definitions and icons for already tracked data and only remove the detection?

Now already tracked data isn't displayed correct anymore after an update...

Changed 4 months ago by vipsoft

We're only striving for API backward compatibility. Theoretically, users can delete archives and re-trigger archiving to reprocess reports.

Changed 4 months ago by matt

Steve can you post a screenshot of what you experience (broken BC?) ?

Windows Phone market share is reportedly dropping; maybe we should drop the version number?

Definitely a good idea to drop Windows phone OS version number, since we don't track these for other phones

Changed 4 months ago by SteveG

Well, as an automatic update doesn't delete the images we removed in svn, the only thing that might be displayed "incorrect" is an old "short" name for windows phone os. (see screenshot)

Changed 4 months ago by SteveG

Changed 4 months ago by matt

  • status changed from closed to reopened
  • resolution fixed deleted

I saw it on the demo too, I think it makes sense to display a better name rather than raise questions (people will think this is a bug for sure)

Anthon do you think it's a quick fix?

Cheers!

Changed 4 months ago by matt

  • status changed from reopened to closed
  • resolution set to fixed

(In [5748]) Fixes #2824

Restoring the display of Windows phones for backward compatibility. Kuddos Anthon for fixing this ticket :)

Note: See TracTickets for help on using tickets.