New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean-up Windows Phone and Windows Mobile version detection #2824
Comments
OS detection algorithm is different from the browser detection algorithm. It's not really future-proofable, eg win 3.1, win 95x, win 3.51, win nt4, win 2k, win xp, win vista, win 7 are derived from the product names. |
Thanks for the details, no problem if it's not future proof. |
(In [5672]) refs #2824 - add placeholders for other Windows Phone and Windows Mobile versions (past & future); Windows operating systems are the only ones we identify by version ... why? also, Windows Phone market share is reportedly dropping; maybe we should drop the version number? |
(In [5673]) fixes #2824 |
Shouldn't we leave the old definitions and icons for already tracked data and only remove the detection? Now already tracked data isn't displayed correct anymore after an update... |
We're only striving for API backward compatibility. Theoretically, users can delete archives and re-trigger archiving to reprocess reports. |
Steve can you post a screenshot of what you experience (broken BC?) ?
Definitely a good idea to drop Windows phone OS version number, since we don't track these for other phones |
Well, as an automatic update doesn't delete the images we removed in svn, the only thing that might be displayed "incorrect" is an old "short" name for windows phone os. (see screenshot) |
Attachment: |
I saw it on the demo too, I think it makes sense to display a better name rather than raise questions (people will think this is a bug for sure) Anthon do you think it's a quick fix? Cheers! |
(In [5748]) Fixes #2824 |
See forum post: http://forum.piwik.org/read.php?3,83981
Let's check that the parsing algorithm will automatically detect further Windows Phone X updates in user agents.
The text was updated successfully, but these errors were encountered: