Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#2845 closed Bug (fixed)

javascript error on Goals page in IE 7 due to unexpected comma

Reported by: Volox Owned by:
Priority: normal Milestone: 1.7 Piwik 1.7
Component: UI - UX (AngularJS, twig, less) Keywords:
Cc: Sensitive: no

Description

When one goes to the Goals page in IE 7 they get the "Error on Page" indicator in the status bar at the bottom and none of the links for viewing by type work. For example, if you want to view goals by custom varaibles the link doesn't work.

I looked at the page in FireFox and it works there so this seems to be an issue that is specific to IE. Running Piwik version 1.6.

I finally managed to track down the error by running the various javascript code pieces through jslint.

Inside of table_by_dimension.tpl (in \piwik\plugins\Goals\templates) there is a javascript block that contains the following:

var widgetParameters = {
'module': module,
'action': action,
};

Take the hanging comma off the end of that (right after action) and now all is happy.

Change History (2)

comment:1 Changed 2 years ago by vipsoft (robocoder)

  • Resolution set to fixed
  • Status changed from new to closed

(In [5643]) fixes #2845

comment:2 Changed 2 years ago by vipsoft (robocoder)

  • Milestone set to 1.7 Piwik 1.7

Thanks!

Note: See TracTickets for help on using tickets.