UI: Provide a site selector that would scale to thousands of websites (inline search, auto suggest, ajax)

[mauser]

Create interactive site chooser.

See attachment.

How should it work?

1. when you click on dropdown menu it shows list of sites from piwik installation and and one special item (the first one) called "Search..."
2. when you click "Search..." we transform dropdown menu (select) into input text box
3. in input box we got "x" icon to switch back to dropdown menu (it is already implemented in data tables interface when you want to cancel your search, see screenshot)
4. when you type it displays results and highlight search keyword in javascript popup below, like in compose message in gmail (see screenshot)
5. you can either choose site or cancel search by clicking "x" icon

[mauser]

already implemented interface in data table visualization

[mauser]

gmail interactive dropdown

[mauser]

project of site choose UI

[mauser]

see search UI.png attachment for detailed use case

[matt]

google reader did exactly the same dropdown already! it works great. we should the same :-)

[mauser]

attached an autocompleter after some minor patches, IE compatible now.

[matt]

Cool new feature - here is my code review

• the query to select a website on name matching should reside in the website API rather than CoreController
• pressing enter without selecting a website leads to 404, instead it should trigger the search for the entered keyword
• is the initial load loading all websites? I don't think it is expected, what would happen if the piwik has 10000 websites? Instead, could it load only the first N websites?
• when no result is found, the Loading... should be replaced with "No website found for '$SEARCHED_STRING'"
• on firefox, the arrow on the right is on top the vertical bar on its left, which looks a bit funny
• the font looks different from the font used elsewhere in the UI, should reuse the same CSS class?

When this is bug free, we can integrate this with core, nice new feature.

[mauser]

New version (v3), bug fixed, improvements made.

[vipsoft]

From a maintenance perspective, I'm a little concerned that the jSuggest developer's site has been marked as unsafe. There's also jSuggest "Enhanced",  http://www.rajavarma.com/wp-content/uploads/2009/07/jquery.jSuggest.1.1.js which we should diff against for bug fixes.

Alternatively, see if  https://jqueryui.pbworks.com/Autocomplete (in the development stage) can be used instead of jSuggest.

[matt]

Maciej, what is the status of the site selector? Is this something you are happy pushing to Piwik core? Please validate and I will do the code review.

[vnese]

This is to inform you that jQuery UI 1.8 has hit stable release and autocomplete is included, i dont know if we should switch to using it.

[vipsoft]

vnese: see #1235

[matt]

it would be great to switch to jquery UI, is anyone keen to make the code change (shouldn't be difficult I don't think)?

[matt]

Note: the HTML is now done in trunk, the JS + PHP has to be ported in trunk, from the plugin attached to this ticket.

[matt]

The code is in:  http://dev.piwik.org/trac/browser/trunk/plugins/CoreHome/templates/sites_selection.tpl#L44

[ts77]

Could this be added / implemented also for the websites administration? That one is awfully slow (and sometimes timinig out) with 6000 sites ;)

[mauser]

(In [2720]) fixes #288

[matt]

(In [2723]) Refs #288 Fixing build

[matt]

(In [2724]) Refs #288 Adding css file but still missing

but still missing the autocomplete.js which I don't have - Maciej?

[mauser]

(In [2727]) fixes #288 added missing autocomplete.js

[matt]

(In [2732]) Refs #288

[matt]

ts77, can you please contact me at matt att piwik.org? would love to hear a bit more about your use case of 6k sites, how is your experience with Piwi, and how we can improve it with that many websites. Thanks