Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Provide a site selector that would scale to thousands of websites (inline search, auto suggest, ajax) #5708

Closed
zawadzinski opened this issue Jul 7, 2008 · 25 comments
Assignees
Labels
Critical Indicates the severity of an issue is very critical and the issue has a very high priority. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone

Comments

@zawadzinski
Copy link
Contributor

Create interactive site chooser.

See attachment.

How should it work?
1. when you click on dropdown menu it shows list of sites from piwik installation and and one special item (the first one) called “Search…”
2. when you click “Search…” we transform dropdown menu (select) into input text box
3. in input box we got “x” icon to switch back to dropdown menu (it is already implemented in data tables interface when you want to cancel your search, see screenshot)
4. when you type it displays results and highlight search keyword in javascript popup below, like in compose message in gmail (see screenshot)
5. you can either choose site or cancel search by clicking “x” icon

@zawadzinski
Copy link
Contributor Author

Attachment: already implemented interface in data table visualization
[close search.png](http://issues.piwik.org/attachments/5708/close_search.png)

@zawadzinski
Copy link
Contributor Author

Attachment: gmail interactive dropdown
[search results.png](http://issues.piwik.org/attachments/5708/search_results.png)

@zawadzinski
Copy link
Contributor Author

Attachment: project of site choose UI
[search ui.png](http://issues.piwik.org/attachments/5708/search_ui.png)

@zawadzinski
Copy link
Contributor Author

see search UI.png attachment for detailed use case

@mattab
Copy link
Member

mattab commented Jul 26, 2008

Attachment: google reader did exactly the same dropdown already! it works great. we should the same :-)
[google-reader-selector.jpg](http://issues.piwik.org/attachments/5708/google-reader-selector.jpg)

@zawadzinski
Copy link
Contributor Author

Attachment:
autocompleter.tar.gz

@zawadzinski
Copy link
Contributor Author

Attachment:
autocompleter v2.zip

@zawadzinski
Copy link
Contributor Author

attached an autocompleter after some minor patches, IE compatible now.

@mattab
Copy link
Member

mattab commented Oct 9, 2009

Cool new feature - here is my code review

  • the query to select a website on name matching should reside in the website API rather than CoreController
  • pressing enter without selecting a website leads to 404, instead it should trigger the search for the entered keyword
  • is the initial load loading all websites? I don't think it is expected, what would happen if the piwik has 10000 websites? Instead, could it load only the first N websites?
  • when no result is found, the Loading... should be replaced with "No website found for '$SEARCHED_STRING'"
  • on firefox, the arrow on the right is on top the vertical bar on its left, which looks a bit funny
  • the font looks different from the font used elsewhere in the UI, should reuse the same CSS class?

When this is bug free, we can integrate this with core, nice new feature.

@zawadzinski
Copy link
Contributor Author

Attachment:
autocompleter v3.zip

@zawadzinski
Copy link
Contributor Author

New version (v3), bug fixed, improvements made.

@robocoder
Copy link
Contributor

From a maintenance perspective, I'm a little concerned that the jSuggest developer's site has been marked as unsafe. There's also jSuggest "Enhanced", http://www.rajavarma.com/wp-content/uploads/2009/07/jquery.jSuggest.1.1.js which we should diff against for bug fixes.

Alternatively, see if https://jqueryui.pbworks.com/Autocomplete (in the development stage) can be used instead of jSuggest.

@mattab
Copy link
Member

mattab commented Feb 19, 2010

Maciej, what is the status of the site selector? Is this something you are happy pushing to Piwik core? Please validate and I will do the code review.

@anonymous-matomo-user
Copy link

This is to inform you that jQuery UI 1.8 has hit stable release and autocomplete is included, i dont know if we should switch to using it.

@robocoder
Copy link
Contributor

vnese: see #1235

@mattab
Copy link
Member

mattab commented Apr 29, 2010

it would be great to switch to jquery UI, is anyone keen to make the code change (shouldn't be difficult I don't think)?

@mattab
Copy link
Member

mattab commented Jul 17, 2010

Note: the HTML is now done in trunk, the JS + PHP has to be ported in trunk, from the plugin attached to this ticket.

@mattab
Copy link
Member

mattab commented Jul 17, 2010

@anonymous-matomo-user
Copy link

Could this be added / implemented also for the websites administration?
That one is awfully slow (and sometimes timinig out) with 6000 sites ;)

@zawadzinski
Copy link
Contributor Author

(In [2720]) fixes #5708

@mattab
Copy link
Member

mattab commented Jul 27, 2010

(In [2723]) Refs #5708 Fixing build

@mattab
Copy link
Member

mattab commented Jul 27, 2010

(In [2724]) Refs #5708 Adding css file but still missing

but still missing the autocomplete.js which I don't have - Maciej?

@zawadzinski
Copy link
Contributor Author

(In [2727]) fixes #5708
added missing autocomplete.js

@mattab
Copy link
Member

mattab commented Jul 28, 2010

(In [2732]) Refs #5708

@mattab
Copy link
Member

mattab commented Jul 28, 2010

ts77, can you please contact me at matt att piwik.org? would love to hear a bit more about your use case of 6k sites, how is your experience with Piwi, and how we can improve it with that many websites. Thanks

@zawadzinski zawadzinski added this to the Piwik 0.6.5 milestone Jul 8, 2014
@zawadzinski zawadzinski self-assigned this Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical Indicates the severity of an issue is very critical and the issue has a very high priority. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Development

No branches or pull requests

4 participants