Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

piwik cannot decode chinese keywords properly sometime from baidu.com #2901

Closed
anonymous-matomo-user opened this issue Feb 3, 2012 · 6 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@anonymous-matomo-user
Copy link

I see there is a fix on Piwik 0.2.33, FIXED #589 Piwik fails to properly decode and store some chinese keywords (eg. from baidu.com).

But I still see some url with chinese keywords are decoded wrong.
take below link for example, the keywords are ?, but in piwik they become "?", see also in attached screenshot file.
http://www.baidu.com/s?ch=14&ie=utf-8&wd=%E4%BA%8C%E5%BA%A6%E5%AE%AB%E9%A2%88%E7%B3%9C%E7%83%82%E8%83%BD%E6%B2%BB%E5%A5%BD%E5%90%97%3F&searchRadio=on

@anonymous-matomo-user
Copy link
Author

Attachment: screenshot about chinese words decode
baidu.decode.jpg

@robocoder
Copy link
Contributor

There's a new featuren in #2761 that allows multiple encodings. We can try adding utf-8 to the baidu configuration (currently expects gb2312) and edward's url to the unit test.

@mattab
Copy link
Member

mattab commented Feb 4, 2012

IT sounds like new logic might need to be introduced for baidu (use UTF-8 when it is found as a parameter value, default to gb2312 otherwise?)

@robocoder
Copy link
Contributor

(In [5755]) fixes #2901 - thanks edward!

@mattab
Copy link
Member

mattab commented Feb 4, 2012

I was wrong, that's good! :)

@anonymous-matomo-user anonymous-matomo-user added this to the 1.7 Piwik 1.7 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

3 participants