New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that IP is anonymized before the heuristic is applied #2902
Comments
I'm opposed to hardcoded logic for mutual exclusion of activated plugins. Users can/should decide for themselves what level of compliance they'll have. Otherwise we're looking at disablng Provider, UserCountry, and Geolocation plugins, by default. |
I suggested skipping Provider reverse lookup only when IP is anonymized. This is based on the belief (not tested!) that doing the reverse lookup on a wrong IP will maybe add performance overhead, and we don't want to add any slowness in the tracker.
Will GeoIP work "partially" if given an anonymized address? If it will not work, then I think it makes sense to disable them, but only once we confirm that the Geoip lookup will fail (again for performance reasons). But, we would always leave them enabled by default, since IP anonymization is disabled by default. |
At least the User should be warned, which Plugins might not work with 100% accuracy, if the anonymize-IP-Plugin is enabled. If he disables all of these plugins, could be decided by the user himself. Other thoughts? |
(In [5775]) Refs #2902
Refs #1823
|
(In [5776]) Fixes #2902
|
i hate it |
AS per ULD recommendations we need to
See Privacy Analytics
The text was updated successfully, but these errors were encountered: