Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#2922 closed Bug (fixed)

Back button does not work when using Chrome browser

Reported by: matt Owned by:
Priority: critical Milestone: 1.7 Piwik 1.7
Component: UI - UX (AngularJS, twig, less) Keywords:
Cc: Sensitive: no

Description

Regressions

  • Back button does not work anymore in Chrome. The #fragment displays the previous fragment but the menu is not loaded
  • When clicking on the link "Websites" below the graph in the Referrers > Overview page, the "website" report loads OK, but it is not colored orange in the menu

Change History (9)

comment:1 Changed 2 years ago by SteveG (sgiehl)

First point maybe caused by a jQuery update? I will have a look at that.
Second point may be caused by different urls. clicking the menu the link has action=indexWebsites. clicking that website link it is action=getWebsites

comment:2 Changed 2 years ago by SteveG (sgiehl)

(In [5829]) refs #2922 fixes problems with not highlighted menu entries

comment:3 Changed 2 years ago by SteveG (sgiehl)

hm... had that history back for chrome ever worked? Just tested it in piwik 1.6 and even in an 1.0, but it didn't work in both. Maybe we need to switch the history plugin to get it fixed.

comment:4 Changed 2 years ago by SteveG (sgiehl)

  • Resolution set to fixed
  • Status changed from new to closed

(In [5832]) fixes #2922 replaced jquery.history plugin with an newer version. tested history function in IE 7-9, Chrome, Safari (Win), Opera, Firefox - works so far :)
@matt would you please test that, too. Didn't have much time for that right now.

comment:5 Changed 2 years ago by matt (mattab)

  • Summary changed from trunk: Regressions in menu when using Chrome browser to Back button does not work when using Chrome browser

Steve that's great!! thanks for the quick fixes. Even better that it didn't use to work and now it does ;)

comment:6 Changed 2 years ago by matt (mattab)

  • Resolution fixed deleted
  • Status changed from closed to reopened

There is one regression: clicking on the same menu again does not reload the content. Clicking on the same menu should reload the content.

comment:7 Changed 2 years ago by SteveG (sgiehl)

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [5853]) fixes #2922 needed to patch the new history plugin as the reload was prevented there. Only tested that changes in newer browsers which supports the hashchange event (see http://help.dottoro.com/ljgggdjt.php for supported browsers)

comment:8 Changed 2 years ago by SteveG (sgiehl)

btw. current implementation does not save the reload in history. that meens hitting the back button after the reload switches back to the hash that was loaded before the hash that was reloaded.

comment:9 Changed 2 years ago by matt (mattab)

I thought you were sleeping so I was trying to fix the problem myself but I already spent 40 minutes on it and couldn't find the fix!! THANKS!

Note: See TracTickets for help on using tickets.