Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back button does not work when using Chrome browser #2922

Closed
mattab opened this issue Feb 13, 2012 · 11 comments
Closed

Back button does not work when using Chrome browser #2922

mattab opened this issue Feb 13, 2012 · 11 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. Critical Indicates the severity of an issue is very critical and the issue has a very high priority.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Feb 13, 2012

Regressions

  • Back button does not work anymore in Chrome. The #fragment displays the previous fragment but the menu is not loaded
  • When clicking on the link "Websites" below the graph in the Referrers > Overview page, the "website" report loads OK, but it is not colored orange in the menu
@sgiehl
Copy link
Member

sgiehl commented Feb 13, 2012

First point maybe caused by a jQuery update? I will have a look at that.
Second point may be caused by different urls. clicking the menu the link has action=indexWebsites. clicking that website link it is action=getWebsites

@sgiehl
Copy link
Member

sgiehl commented Feb 13, 2012

(In [5829]) refs #2922 fixes problems with not highlighted menu entries

@sgiehl
Copy link
Member

sgiehl commented Feb 13, 2012

hm... had that history back for chrome ever worked? Just tested it in piwik 1.6 and even in an 1.0, but it didn't work in both. Maybe we need to switch the history plugin to get it fixed.

@sgiehl
Copy link
Member

sgiehl commented Feb 13, 2012

(In [5832]) fixes #2922 replaced jquery.history plugin with an newer version. tested history function in IE 7-9, Chrome, Safari (Win), Opera, Firefox - works so far :)
@matt would you please test that, too. Didn't have much time for that right now.

@mattab
Copy link
Member Author

mattab commented Feb 14, 2012

Steve that's great!! thanks for the quick fixes. Even better that it didn't use to work and now it does ;)

@mattab
Copy link
Member Author

mattab commented Feb 15, 2012

There is one regression: clicking on the same menu again does not reload the content. Clicking on the same menu should reload the content.

@sgiehl
Copy link
Member

sgiehl commented Feb 16, 2012

(In [5853]) fixes #2922 needed to patch the new history plugin as the reload was prevented there. Only tested that changes in newer browsers which supports the hashchange event (see http://help.dottoro.com/ljgggdjt.php for supported browsers)

@sgiehl
Copy link
Member

sgiehl commented Feb 16, 2012

btw. current implementation does not save the reload in history. that meens hitting the back button after the reload switches back to the hash that was loaded before the hash that was reloaded.

@mattab
Copy link
Member Author

mattab commented Feb 16, 2012

I thought you were sleeping so I was trying to fix the problem myself but I already spent 40 minutes on it and couldn't find the fix!! THANKS!

@mattab mattab added this to the 1.7 Piwik 1.7 milestone Jul 8, 2014
@NCJasper
Copy link

I'm still experiencing this issue. Have it ever been fixed?

@tsteur
Copy link
Member

tsteur commented Oct 17, 2019

Yes should work

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Critical Indicates the severity of an issue is very critical and the issue has a very high priority.
Projects
None yet
Development

No branches or pull requests

4 participants