Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate enable_framed_logins #2940

Closed
mattab opened this issue Feb 16, 2012 · 1 comment
Closed

deprecate enable_framed_logins #2940

mattab opened this issue Feb 16, 2012 · 1 comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Feb 16, 2012

When enable_framed_logins=1
Login can be made from the iframe.
However the iframe redirects to a Piwik page which is prevented to load, since enable_framed_pages=0 by default.

Therefore I propose to

  • deprecate enable_framed_logins
  • for BC, enable_framed_logins=1 is similar to enable_framed_pages=1
  • only use enable_framed_pages for both logins and standard pages
  • update the FAQ mentionning these settings
@mattab
Copy link
Member Author

mattab commented Feb 23, 2012

(In [5888]) Fixes #2940

  • Remove enable_framed_logins since we now have the more general enable_framed_pages
  • Still backward compatible if user has set enable_framed_logins =1 in a previous version
  • updated the iframe login FAQ
  • Also updated iframe FAQ to include mention of the setting

@mattab mattab added this to the 1.7.x - Piwik 1.7.1 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

1 participant