Opened 2 years ago

Closed 2 years ago

#2940 closed Bug (fixed)

deprecate enable_framed_logins

Reported by: matt Owned by:
Priority: normal Milestone: 1.7.x - Piwik 1.7.1
Component: Core Keywords:
Cc: Sensitive: no

Description

When enable_framed_logins=1
Login can be made from the iframe.
However the iframe redirects to a Piwik page which is prevented to load, since enable_framed_pages=0 by default.

Therefore I propose to

  • deprecate enable_framed_logins
  • for BC, enable_framed_logins=1 is similar to enable_framed_pages=1
  • only use enable_framed_pages for both logins and standard pages
  • update the FAQ mentionning these settings

Change History (1)

comment:1 Changed 2 years ago by matt (mattab)

  • Resolution set to fixed
  • Status changed from new to closed

(In [5888]) Fixes #2940

  • Remove enable_framed_logins since we now have the more general enable_framed_pages
  • Still backward compatible if user has set enable_framed_logins =1 in a previous version
  • updated the iframe login FAQ
  • Also updated iframe FAQ to include mention of the setting
Note: See TracTickets for help on using tickets.