You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
mattab opened this issue
Feb 22, 2012
· 6 comments
Labels
BugFor errors / faults / flaws / inconsistencies etc.MajorIndicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Rather than failing with error message "timezone not valid"
we should display a proper error message "User does not have privilege"
update the requirement documentation to detail which privileges are required
Problem in code:
This issue arises from a call to Piwik_SetOption (when it's called from setDefaultTimezone) that causes an exception to be thrown because the public function "set" in Option.php fails at it's database call. This is due to insufficient database user privileges. Granting the piwik DB user more privileges allows the setup to continue.
Maybe we could have a page that checks the database user grants before continuing the setup. Or at-least some docs on the needed permissions for the piwik DB user since not everyone will be doing a "grant all".
The text was updated successfully, but these errors were encountered:
The check is provided as an extra form validation for the database setup page. If the user doesn't have the right privileges, a message displaying all the required privileges is displayed. As far as I can tell, its not possible to make a validation error message depend on the form values themselves, so that's as specific as it gets.
Thanks vipsoft for the suggestion, and Kuddos capedfuzz for this clean patch!
Code review:
I would maybe detail the error a bit more in Installation_InsufficientPrivileges maybe you can add something along the lines of "You can use a tool such as phpMyAdmin (or a SQL query). If you do not know what this means, please ask your sysadmin to grant these privileges to the %s user".
TEST_TABLE_NAME and TEST_TEMP_TABLE_NAME couild be "piwik_test_table_tmp" and "piwik_test_table" just in case they're somehow left in there
can you confirm you checked individually each missing right and that the code works in all the cases? (I'm thinking in particular if the error codes in isAccessDenied() would cover all use cases of missing permissions)
Regarding my commit: I tested w/ every privilege, every needed privilege, w/ every needed privilege except one (for each privilege), and w/ no privileges. Also tested to make sure other fields were checked properly. Everything worked.
BugFor errors / faults / flaws / inconsistencies etc.MajorIndicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Reported in forum:
Rather than failing with error message "timezone not valid"
Problem in code:
This issue arises from a call to Piwik_SetOption (when it's called from setDefaultTimezone) that causes an exception to be thrown because the public function "set" in Option.php fails at it's database call. This is due to insufficient database user privileges. Granting the piwik DB user more privileges allows the setup to continue.
Maybe we could have a page that checks the database user grants before continuing the setup. Or at-least some docs on the needed permissions for the piwik DB user since not everyone will be doing a "grant all".
The text was updated successfully, but these errors were encountered: