Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard widget layout resets to default layout unexpectedly #2972

Closed
mattab opened this issue Feb 23, 2012 · 1 comment
Closed

Dashboard widget layout resets to default layout unexpectedly #2972

mattab opened this issue Feb 23, 2012 · 1 comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone
1.7.1

Comments

@mattab
Copy link
Member

mattab commented Feb 23, 2012

From forum report

How to reproduce?

Default dashboard
I remove the Widget "Visitors in Real Time" and "Visitor countries".
Next I go to Visitors -> Custom Variables.
Clicking the "Plus-Button" for more Data in the Table.
Click on Dashboard for the "Home-Site" and all widgets/layouts are reseted to the default.
This behavior do not depend on the language I selected (tested in German and English).

Tested on Firefox 10.0.2 and Chrome 17.0.963.56.
@mattab
Copy link
Member Author

mattab commented Feb 24, 2012

(In [5902]) Fixes #2972

When a click on the menu, we delete the dashboard object. This ensures that the function notifyDashboardViewDataTableChange is not called when we are outside of the dashboard. There is probably a better way to do it, but a one line hack can't be that bad...

Here is the stacktrace that triggered the saveLayout call:

saveLayout()Dashbo...0aefe4d (line 408)
setDataTableViewChanged(uniqueId=undefined, newViewDataTable="tableAllColumns")Dashbo...0aefe4d (line 391)
notifyDashboardViewDataTableChange(domWidget=[a.tableIcon], newViewDataTable="tableAllColumns")datata...0aefe4d (line 742)
(?)()datata...0aefe4d (line 505)
add(c=Object { originalEvent=Event click, type="click", timeStamp=12938312, more...})jquery...0aefe4d (line 3)
add(a=click clientX=66, clientY=313)jquery...0aefe4d (line 3)

@mattab mattab added this to the 1.7.x - Piwik 1.7.1 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Milestone
1.7.1
Development

No branches or pull requests
1 participant
@mattab