Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embedded dashboard does not load unless enable_framed_pages=1 (regression) #2980

Closed
mattab opened this issue Feb 27, 2012 · 3 comments
Closed

Embedded dashboard does not load unless enable_framed_pages=1 (regression) #2980

mattab opened this issue Feb 27, 2012 · 3 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
1.7.1

Comments

@mattab
Copy link
Member

mattab commented Feb 27, 2012

Similar to bug fixed in [5917] but I missed checking for the dashboard embed
@mattab
Copy link
Member Author

mattab commented Feb 27, 2012

(In [5926]) Fixes #2980

@robocoder
Copy link
Contributor

If you want the last one to prevail, perhaps use:

    @header('X-Frame-Options: '. (string)$this->xFrameOptions, $replace = true);

@mattab
Copy link
Member Author

mattab commented Feb 28, 2012

"The optional replace parameter indicates whether the header should replace a previous similar header, or add a second header of the same type. By default it will replace"

so it's all good :)

@mattab mattab added this to the 1.7.x - Piwik 1.7.1 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
1.7.1
Development

No branches or pull requests
2 participants
@mattab @robocoder