Opened 2 years ago

Closed 18 months ago

#3023 closed Bug (fixed)

When anonimize IP is enabled, consider doing Provider / GeoIP lookup faking the last IP byte to 1 ?

Reported by: matt Owned by:
Priority: major Milestone: 1.12.x - Piwik 1.12.x
Component: Core Keywords:
Cc: Sensitive: no

Description

It is suggested in the forums that major internet providers own the full range of IP.

When IP has only 1 byte anonimized, could we use the assumption that they own the x.y.z.1 IP, and do the provider lookup on this IP, instead of x.y.z.0 which does not work (and is currently disabled)?

It might fail to return the proper Provider in some cases, but for most cases, it should work. Thoughts?

Change History (4)

comment:1 Changed 23 months ago by matt (mattab)

  • Summary changed from When anonimize IP is enabled, consider doing Provider lookup faking the last IP byte to 1 ? to When anonimize IP is enabled, consider doing Provider / GeoIP lookup faking the last IP byte to 1 ?

We should also consider GeoIP which has the same issue, how about replacing bytes by 0 and doing lookup in GeoIP based on that? I have the feeling I had this discussion already...

comment:2 Changed 23 months ago by matt (mattab)

  • Priority changed from normal to major

comment:3 Changed 19 months ago by mstenz

Hi,
this issue is also important to me. Because I don't have the ability to look deep in the code I don't know why this is not possible, but for me the best solution will be

  • getting the provider
  • anonimize the ip afterwards

I saw in the forum that this is maybe due tu privacy reasons, but for me this is not the case. the ip address is not needed to be saved to any database, its just used in the code (ram) and then anonymized directly.

rgds.
Michael

Last edited 19 months ago by mstenz (previous) (diff)

comment:4 Changed 18 months ago by capedfuzz (diosmosis)

  • Resolution set to fixed
  • Status changed from new to closed

Anonymization works w/ GeoIP, though can become less accurate (depending on number of bytes anonymized).

Note: See TracTickets for help on using tickets.