Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trunk: php 5.4. incompatibilities #3030

Closed
robocoder opened this issue Mar 10, 2012 · 9 comments
Closed

trunk: php 5.4. incompatibilities #3030

robocoder opened this issue Mar 10, 2012 · 9 comments
Assignees
@robocoder
Labels
Bug For errors / faults / flaws / inconsistencies etc. Critical Indicates the severity of an issue is very critical and the issue has a very high priority.
Milestone
1.12.x

Comments

@robocoder
Copy link
Contributor

With E_STRICT, we're getting the following errors:

Unexpected PHP error variables should be passed by reference severity [E_STRICT]

Review where we use reset(), current(), end(), each(), prev(), and next().
@robocoder
Copy link
Contributor Author

(In [6031]) fixes #3030 - php 5.4.0 incompatibilities with E_STRICT

Now that php 5.4.0 is "official", I've bumped the CI server up to using that as the default php version.

@robocoder
Copy link
Contributor Author

segfault...

@robocoder
Copy link
Contributor Author

(In [6032]) refs #3030 - for debug

@robocoder
Copy link
Contributor Author

(In [6033]) refs #3030 - revert debug

@robocoder
Copy link
Contributor Author

I'm not getting any useful debugging information from the log files.

2012-03-10 17:54:22.158:WARN::Non-zero exit status (255) from CGI program: /..../build/index.php
2012-03-10 17:54:23.436:WARN::Non-zero exit status (139) from CGI program: /..../build/index.php
Segmentation fault

@robocoder
Copy link
Contributor Author

p.s. I rolled back to php 5.3.10 on the CI server

@robocoder
Copy link
Contributor Author

I couldn't reproduce this locally. I had to disable display_errors and E_STRICT to get Piwik 1.0 to install. But it updated to trunk without error.

@mattab
Copy link
Member

mattab commented Mar 12, 2012

Great job Anthon on the 5.4 work. You are our Samurai of the bleeding edge technologies ;)

@mattab
Copy link
Member

mattab commented Mar 20, 2012

(In [6068]) refs #3030 Honour php.ini setting.

The fact that errors are displayed is one of the key factors that help us troubleshoot users, losing error and NOTICES messages would be a lot more support pain...

we still recommend power users to set it to off: http://piwik.org/security/how-to-secure-piwik/

@robocoder robocoder added this to the 1.12.x - Piwik 1.12.x milestone Jul 8, 2014
@robocoder robocoder self-assigned this Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robocoder robocoder

Labels
Bug For errors / faults / flaws / inconsistencies etc. Critical Indicates the severity of an issue is very critical and the issue has a very high priority.
Projects
None yet
Milestone
1.12.x
Development

No branches or pull requests
2 participants
@mattab @robocoder