Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

&segment= parameter should be forwarded to the hashtag when clicking on menus #3060

Closed
mattab opened this issue Mar 20, 2012 · 3 comments
Closed

&segment= parameter should be forwarded to the hashtag when clicking on menus #3060

mattab opened this issue Mar 20, 2012 · 3 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone
1.12.x

Comments

@mattab
Copy link
Member

mattab commented Mar 20, 2012

currently &segment=country==fr is not forwarded to other menus clicked (it disappears). We should forward it as well as date/period/idGoal/etc. so that at least segmentation works when we manually add it to URL, while we're waiting for #2135
@julienmoumne
Copy link
Member

+1

I regularly filter stats based on a custom variable (user login) and I always need to edit the URL to reapply the filter.

@mattab
Copy link
Member Author

mattab commented Mar 22, 2012

More complicated than I thought. I think there is a bug in the menu actually.

What I did:

  • Go to index.php?module=CoreHome&action=index&idSite=1&period=day&date=yesterday#module=Actions&action=indexPageUrls&idSite=1&period=day&date=yesterday&segment=country==xx
    • It loads the content as expected with the segment applied
  • OPen firebug > Net panel
  • Click on the same submenu (or any other)
  • You will notice 2 http requests made instead of one:
    • Expected: index.php?module=CoreHome&action=index&idSite=1&period=day&date=yesterday#module=Actions&action=indexPageUrls&idSite=1&period=day&date=yesterday&segment=country==xx
    • But then it also triggers (it seems at the same time) another request this time to the page without the segment: index.php?module=CoreHome&action=index&idSite=1&period=day&date=yesterday#module=Actions&action=indexPageUrls&idSite=1&period=day&date=yesterday

I have tried looking for the bug but couldn't pin point it...

@mattab
Copy link
Member Author

mattab commented Mar 22, 2012

(In [6090]) Fixes #3060 How to spend 2 hours fixing some annoying bug ;)

@mattab mattab added this to the 1.12.x - Piwik 1.12.x milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Milestone
1.12.x
Development

No branches or pull requests
2 participants
@mattab @julienmoumne