Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#3102 closed Task (fixed)

Allow to customize the maximum URL split which defaults to 10 URL directories max

Reported by: matt Owned by:
Priority: normal Milestone: Piwik 1.8
Component: Core Keywords:
Cc: Sensitive: no

Description (last modified by matt)

The harcoded "10" should be customizable via config file setting.

See in plugins/Actions/Actions.php

$limitLevelSubCategory = 10

Change History (5)

comment:1 Changed 2 years ago by matt (mattab)

  • Description modified (diff)
  • Milestone changed from 1.7.x - Piwik 1.7.x to 1.7.2 - Piwik 1.7.2

comment:2 Changed 2 years ago by capedfuzz (diosmosis)

  • Resolution set to fixed
  • Status changed from new to closed

(In [6278]) Fixes #3102, added config setting 'action_category_level_limit' as replacement for Piwik_Actions::$limitLevelSubCategory constant.

comment:3 Changed 2 years ago by matt (mattab)

  • Resolution fixed deleted
  • Status changed from closed to reopened

Thanks for the change. It allows up to level 15, but in this case we would liket o really allow for more which some users will want to do for sure ;)

So I propose to add a setter on DataTable to increase the MAXIMUM_DEPTH_LEVEL_ALLOWED which should be changed to a private member.

This way it would work in all cases. We don't need to enforce an absolute max, users will be careful changing these values and know what risks they take (php memory exhausted error mainly)

comment:4 Changed 2 years ago by capedfuzz (diosmosis)

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [6294]) Fixes #3102, removed upper limit for 'action_category_level_limit' config setting by making MAXIMUM_DEPTH_LEVEL_ALLOWED settable.

comment:5 Changed 2 years ago by matt (mattab)

(In [6307]) Refs #3102 removing unused function

Note: See TracTickets for help on using tickets.