Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/Url.php: getCurrentHost() should fallback to SERVER_ADDR #3108

Closed
robocoder opened this issue Apr 13, 2012 · 1 comment
Closed

core/Url.php: getCurrentHost() should fallback to SERVER_ADDR #3108

robocoder opened this issue Apr 13, 2012 · 1 comment
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone

Comments

@robocoder
Copy link
Contributor

If the request doesn't contain a Host: header, we should probably default to the server's IP address, $_SERVER['SERVER_ADDR'] instead of unknown

Investigate impact.

@robocoder
Copy link
Contributor Author

(In [6208]) fixes #3108 - fallback to SERVER_ADDR if HTTP_HOST not defined

@robocoder robocoder added this to the 1.x - Piwik 1.x milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

No branches or pull requests

1 participant