Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trunk: Screen Resolution showing as unknown for IE visitors in Piwik 1.7.2 RC8 #3141

Closed
anonymous-matomo-user opened this issue May 10, 2012 · 6 comments
Closed

trunk: Screen Resolution showing as unknown for IE visitors in Piwik 1.7.2 RC8 #3141

anonymous-matomo-user opened this issue May 10, 2012 · 6 comments
Assignees
@robocoder
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone
1.8

Comments

@anonymous-matomo-user
Copy link

Since switching from version 1.7.1 to 1.7.2_RC8 I've noticed a lot of the screen resolutions show as unknown whereas before I did not have this problem.

unknown     487
1366x768    72
1680x1050   41
320x480     50
1280x800    48

They all seem to be IE based browsers with few exceptions, attaching section of piwik_log_visit table as CSV for more details

A byproduct of this problem is that all unknown screen resolutions are being classified as Mobile Screen types, resulting in a majority of the screen types being mobile when they should be in a minority:

Mobile  540
Wide    273
Normal  90
Dual    1
@anonymous-matomo-user
Copy link
Author

Attachment: Section of log_visit database as CSV
piwik_log_visit_unknown.csv

@anonymous-matomo-user
Copy link
Author

Problem is in piwik.js

This is since detectBrowserFeatures() sets res and due to the new regex check that doesnt call the function if it detects "MSIE" in useragent (Row 1977 in https://github.com/piwik/piwik/blob/master/js/piwik.js).

I don't know how to compress .js like it's done here so could use some help.

Haven't found where unknown screen resolution defaults to mobile yet.

@anonymous-matomo-user
Copy link
Author

I don't know the routines for suggesting changes here so if anyone wants to grab this and improve/move forward I would be thankful.

Suggested changes for piwik/plugins/UserSettings/functions.php
http://pastebin.com/YG6Btb3Y

Suggested changes for piwik/piwik.js
http://pastebin.com/uGFPXryM
Should be looked over for optimization

@robocoder
Copy link
Contributor

Nice catch!

@robocoder
Copy link
Contributor

(In [6256]) refs #3141

@robocoder
Copy link
Contributor

This was a regression from #2962.

@anonymous-matomo-user anonymous-matomo-user added this to the Piwik 1.8 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robocoder robocoder

Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Milestone
1.8
Development

No branches or pull requests
2 participants
@robocoder @anonymous-matomo-user