New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UX: Reuse the website selector with inline search in all places in the UI #3202
Comments
Attachment: Patch for this issue. |
I uploaded a patch for this issue that makes it possible to use the website selector in different places and puts it to use in the UsersManager screen. matt, can you review it and let me know what you think? |
Thanks for the patch!
|
(In [6556]) Fixes #3202, allowed site selector widget to be used in other places than the top bar, and put widget to use in 'report to load by default' setting. |
Committed. Regarding updating old JS code: I think it might be a good idea to rewrite the widgets as jquery plugins, when the opportunity allows. So you could use more than one of the widgets on the same page, etc. For site selector, the use would change to:
|
Getting many NOTICE errors when loading the user settings page: Notice: Undefined index: rawDate in piwik\svn\trunk\tmp\templates_c%%2E^2E7^2E7E144D%%sites_selection.tpl.php on line 10 see email for more |
(In [6579]) Refs #3202, remove unnecessary hrefs from site selector and hide all sites link when selector used in user settings. |
I think I've fixed those issues, but I can't check. For some reason, I can't reproduce the notices, even though I can prove they're happening (nothing in the screen or the log). Let me know if my commit does the trick. |
Code review:
|
I noticed a regression: clicking on a site in the selector should collapse the selector. this way the user eyes focus on the Loading indicator at the right, this shows well that the click was taken into consideration |
(In [6616]) Refs #3202, added modified access manager page & visitor generator plugin to use the autocompleting site selector. Notes:
|
(In [6627]) Refs #3202, fix notice in sites_selection.tpl. |
(In [6629]) Refs #3202, fix bug in sites_selection.tpl that affected VisitorGenerator. |
Very Nice work :) |
As per title: Increase websites from listing 10 currently to listing up to 200 max in Report to load by default > Dashboard for a specific website
Reported in forum
The text was updated successfully, but these errors were encountered: