I can't wait to see code coverage metrics :) Thank you again for tackling this difficult & long project of converting tests to a new framework!

Already converted all core and plugin tests in the last few days to run with phpunit. But the integration tests are bit hard to migrate. Most of them are somehow still failing.

(In [6489]) refs #3227 added first phpunit tests and phpunit xml configuration

(In [6490]) refs #3227 added more phpunit tests

(In [6491]) refs #3227 added test files

(In [6493]) refs #3227 added/improved some more tests

(In [6494]) refs #3227 added/improved some more tests

(In [6495]) refs #3227 more and more tests completely converted :)

(In [6496]) refs #3227 more tests

(In [6497]) refs #3227 more tests

(In [6498]) refs #3227 datatable renderer tests

(In [6499]) refs #3227 more tests

(In [6502]) refs #3227 added first database tests

(In [6504]) refs #3227 more tests converted to PHPUnit

(In [6505]) refs #3227 optimized/added phpunit tests

(In [6507]) refs #3227 fixed some tests

(In [6508]) refs #3227 fixed tests expecting an exception, as current phpunit version doesn't support expecting standard exceptions

(In [6511]) refs #3227 added tests for uncovered methods

(In [6512]) refs #3227 wrote some tests for Piwik_Access / added missing tests for Piwik_Unzip

(In [6536]) refs #3227 added releasechecklist tests

(In [6537]) refs #3227 prevent svn to replace the inline $Id's

(In [6560]) refs #3227 added first versions of some integration tests. there are still many things to be improved. in order to make them running correct the HTTP_HOST config needs to be changed in phpunit.xml. some of the tests aren't running because of encoding problems. I'll maybe have a look at that later

(In [6566]) refs #3227 added, improved integration tests

(In [6568]) refs #3227 added more integration tests

(In [6571]) refs #3227 added another integration test

Thanks Stefan!! great changes & new features we will benefit with phpunit...

Looking forward to the end of the project, to enjoy PHPUnit fully and also avoid maintaining both test suites which will would be a challenge long term.

(In [6574]) refs #3227 added integration test

(In [6582]) refs #3227 - allow devs to have a local, customized phpunit.xml

Replying to SteveG:

(In [6560]) refs #3227 added first versions of some integration tests. there are still many things to be improved. in order to make them running correct the HTTP_HOST config needs to be changed in phpunit.xml. some of the tests aren't running because of encoding problems. I'll maybe have a look at that later

Would there be any way not to set the HOST in phpunit.xml and automatically read it from HTTP_HOST?

As PHPUnit is executed in command line mode the HTTP_HOST variable is set to the hosts name. that might not be the same host apache is listening. It might also be possible you need to adjust REQUEST_URI as piwik might not be located in /piwik

(In [7242]) refs #3227 removing integration simple tests

(In [7244]) refs #3227 moving integration result files

(In [7245]) refs #3227 moving integration result files

(In [7246]) refs #3227 moving integration result files

(In [7247]) refs #3227 moving integration result files

(In [7248]) refs #3227 moving integration result files

(In [7249]) refs #3227 moving integration result files

(In [7250]) refs #3227 moving integration result files

(In [7251]) refs #3227 moving integration result files

(In [7252]) refs #3227 moving integration result files

(In [7253]) refs #3227 moving integration result files

(In [7318]) refs #3227 fixing some tests

Great it looks like it's very close to closing the ticket!

Code Feedback:

• Can you confirm you have moved the expected files and so they haven't changed during migration?
• I notice 4 remaining .test.php files to migrate/delete
• I wonder about Plugins testability and PHPUnit running $pluginX tests files as a new test group (cf email)

Very nice! I cant wait now to enjoy Jenkins+PHPUnit....!

(In [7456]) refs #3227 removing old benchmark tests

(In [7487]) refs #3227 improvements to languagemanager tests; now every language is run as a seperate test case

(In [7548]) refs #3227 migrated one remaining test

(In [7549]) refs #3227 migrated last remaining test

(In [7551]) refs #3227 removing remaining simpletest files

(In [7553]) refs #3227 removed duplicate file

Migration nearly finished. Last point on the list should now be: the testability of new plugins (having a official plugin directory in mind). But maybe we should create a seperate ticket for that or handle it as soon as it is realy required.

Ok we will deal with the testability of Plugins in a new ticket. Could you create it, especially if you have some rought ideas on how it could be done with PHPUnit & ant?

Stefan, Kuddos for leading this project to completion! it's such a pleasure working with PHPUnit!

Milestone 1.8.x Piwik 1.8.x deleted