Opened 22 months ago

Closed 14 months ago

Last modified 14 months ago

#3252 closed Bug (fixed)

Update Thunderbird icon and name

Reported by: jawsmith Owned by: Simon Schaufelberger <simonschaufi@…>
Priority: normal Milestone: Future releases
Component: Core Keywords:
Cc: Sensitive: no

Description

Mozilla Thunderbird with User Agent "Mozilla/5.0 (Windows NT 5.1; rv:13.0) Gecko/20120614 Thunderbird/13.0.1" is currently shown with the red Mozilla lizard icon, instead of the blue(ish) icon of Thunderbird, and it will be shown as "Mozilla 13.0" instead of "Thunderbird 13.0". (Unlike Firefox, which is shown as "Firefox 13.0" with respective Firefox icon.)

Just noticed that on feeds picked up by Thunderbird. It might also be of interest on server logs evaluation.

Piwik 1.8.2.

Change History (11)

comment:1 Changed 21 months ago by jawsmith

P.S.: For some reason, when a feed is accessed by Thunderbird, the accessed link is not displayed by Piwik - "0 Action" is shown in the detailed visitor log instead, w/o the link. Whereas when the same feed link is accessed by Firefox, the link gets displayed. I don't know, though, if that is due to a strange Thunderbird feed reading behavior, as there are a whole bunch of open feed tickers for TB. And I remember discussions on taking over the apparently better Firefox feed implementation in future.

An image tracker of the following kind was used:
<img src="http://www.example.com/piwik/js/?idsite=6&amp;rec=1&amp;action_name=/component/content/frontpage&amp;rand=1343695135" style="border:0" alt="" />

The feed passes the W3C feed and XHTML validators.

comment:2 Changed 18 months ago by matt (mattab)

Could you please submit the patch to: http://dev.piwik.org/trac/browser/trunk/libs/UserAgentParser/UserAgentParser.php ? :)

and what is the new icon? Thanks!

Last edited 18 months ago by matt (previous) (diff)

comment:3 Changed 18 months ago by matt (mattab)

  • Milestone changed from 1.9.2 - Piwik 1.9.2 to 1.x - Piwik 1.x

decreasing priority until there is a patch...

comment:4 Changed 17 months ago by matt (mattab)

  • Milestone changed from 1.x - Piwik 1.x to Feature requests
  • Priority changed from low to normal

comment:5 Changed 14 months ago by Simon Schaufelberger <simonschaufi@…>

In 61d65ba7c7abe6325f9c72407e38f2e4d470cc54:

Refs #3252 Update Thunderbird icon and name

comment:6 Changed 14 months ago by Simon Schaufelberger <simonschaufi@…>

  • Owner set to Simon Schaufelberger <simonschaufi@…>
  • Resolution set to fixed
  • Status changed from new to closed

In d9d25ba45f0c7192c4be56d86c737f7a8ad09d97:

fixes #3252 Update Thunderbird icon and name

comment:7 Changed 14 months ago by Fabian Becker <halfdan@…>

In 58009e48ca18e657e073f1d9aecbc98d5f55a72b:

Merge pull request #29 from simonschaufi/ticket_3252

fixes #3252 Update Thunderbird icon and name

Thank you Simon!

comment:8 Changed 14 months ago by Fabian Becker <halfdan@…>

In 170c1e2cf6c944fc7c359fb67999a6ad259f237d:

Add some more tests for Thunderbird recognition.
Reformatted code a bit.

refs #3252

comment:9 Changed 14 months ago by Fabian Becker

In 0e3ad5103f2ba76a18820f64d810a49aa0aaf69e:

Refs #3252 Update Thunderbird icon and name

comment:10 Changed 14 months ago by Fabian Becker

In 8bf8d71f955d5427343115762f68ed6380c608c3:

fixes #3252 Update Thunderbird icon and name

comment:11 Changed 14 months ago by Fabian Becker

In 1f25ab12b6ba857abe0acd4c81a77c9f44b608ff:

Add some more tests for Thunderbird recognition.
Reformatted code a bit.

refs #3252

Note: See TracTickets for help on using tickets.