Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Thunderbird icon and name #3252

Closed
anonymous-matomo-user opened this issue Jun 25, 2012 · 10 comments
Closed

Update Thunderbird icon and name #3252

anonymous-matomo-user opened this issue Jun 25, 2012 · 10 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.

Comments

@anonymous-matomo-user
Copy link

Mozilla Thunderbird with User Agent "Mozilla/5.0 (Windows NT 5.1; rv:13.0) Gecko/20120614 Thunderbird/13.0.1" is currently shown with the red Mozilla lizard icon, instead of the blue(ish) icon of Thunderbird, and it will be shown as "Mozilla 13.0" instead of "Thunderbird 13.0". (Unlike Firefox, which is shown as "Firefox 13.0" with respective Firefox icon.)

Just noticed that on feeds picked up by Thunderbird. It might also be of interest on server logs evaluation.

Piwik 1.8.2.

@anonymous-matomo-user
Copy link
Author

P.S.: For some reason, when a feed is accessed by Thunderbird, the accessed link is not displayed by Piwik - "0 Action" is shown in the detailed visitor log instead, w/o the link. Whereas when the same feed link is accessed by Firefox, the link gets displayed. I don't know, though, if that is due to a strange Thunderbird feed reading behavior, as there are a whole bunch of open feed tickers for TB. And I remember discussions on taking over the apparently better Firefox feed implementation in future.

An image tracker of the following kind was used:
<img src="http://www.example.com/piwik/js/?idsite=6&amp;rec=1&amp;action_name=/component/content/frontpage&amp;rand=1343695135" style="border:0" alt="" />

The feed passes the W3C feed and XHTML validators.

@mattab
Copy link
Member

mattab commented Oct 19, 2012

Could you please submit the patch to: https://github.com/piwik/piwik/blob/master/libs/UserAgentParser/UserAgentParser.php ? :)

and what is the new icon? Thanks!

@mattab
Copy link
Member

mattab commented Oct 20, 2012

decreasing priority until there is a patch...

@anonymous-matomo-user
Copy link
Author

In 61d65ba: Refs #3252 Update Thunderbird icon and name

@anonymous-matomo-user
Copy link
Author

In d9d25ba: fixes #3252 Update Thunderbird icon and name

@anonymous-matomo-user
Copy link
Author

In 58009e4: Merge pull request #29 from simonschaufi/ticket_3252

fixes #3252 Update Thunderbird icon and name

Thank you Simon!

@anonymous-matomo-user
Copy link
Author

In 170c1e2: Add some more tests for Thunderbird recognition.
Reformatted code a bit.

refs #3252

@anonymous-matomo-user
Copy link
Author

In 0e3ad51: Refs #3252 Update Thunderbird icon and name

@anonymous-matomo-user
Copy link
Author

In 8bf8d71: fixes #3252 Update Thunderbird icon and name

@anonymous-matomo-user
Copy link
Author

In 1f25ab1: Add some more tests for Thunderbird recognition.
Reformatted code a bit.

refs #3252

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

2 participants