Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link all external links via proxy script to avoid leaking Referer #3268

Closed
mattab opened this issue Jul 17, 2012 · 4 comments
Closed

Link all external links via proxy script to avoid leaking Referer #3268

mattab opened this issue Jul 17, 2012 · 4 comments
Labels
c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. duplicate For issues that already existed in our issue tracker and were reported previously. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.

Comments

@mattab
Copy link
Member

mattab commented Jul 17, 2012

Currently Piwik links to external websites from the report. This results in the Piwik URL being leaked to the website that probably linked to us. This is not ideal. Instead, we should not link directly from the report to the external URL but instead link to the proxy script which will hide the referrer URL (Piwik URL and its paramters) and redirect the user safely.

This involves following changes:
@mattab
Copy link
Member Author

mattab commented Aug 7, 2012

suggested in #3147

@mattab
Copy link
Member Author

mattab commented Oct 19, 2012

See the first step in #3460

@mattab
Copy link
Member Author

mattab commented Dec 14, 2012

Not sure about this one, since linking all URLS via proxy would prevent from "Copy paste" URLs easily, which could be a usability issue...

@mattab mattab added this to the Future releases milestone Jul 8, 2014
This was referenced Nov 9, 2012
Closed
Closed
@mattab mattab removed the P: normal label Aug 3, 2014
@mattab mattab added c: Usability For issues that let users achieve a defined goal more effectively or efficiently. and removed c: Usability For issues that let users achieve a defined goal more effectively or efficiently. labels Oct 12, 2014
@mattab
Copy link
Member Author

mattab commented Oct 17, 2014

Let's focus on #3147 as other items here are not needed.

@mattab mattab closed this as completed Oct 17, 2014
@mattab mattab added the duplicate For issues that already existed in our issue tracker and were reported previously. label Oct 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. duplicate For issues that already existed in our issue tracker and were reported previously. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mattab