Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visitor Generator to use API call instead of sql query - Best practise #3299

Closed
mattab opened this issue Aug 3, 2012 · 5 comments
Closed
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Aug 3, 2012

Currently the Visitor Generator uses manual call to the DB, instead we should demonstrate best practise and use the recently introduced API to force old reports to be reprocessed, see: http://piwik.org/faq/how-to/#faq_155

@mattab
Copy link
Member Author

mattab commented Aug 3, 2012

Code to replace is in: /trunk/plugins/VisitorGenerator/Controller.php at L72

UI:

  • Customize message
    • If "Browser trigger archiving" is enabled then simply say "The reports will be reprocessed the next time you visit the Piwik reports, it might take a few minutes."
  • If "Browser trigger archiving" is disabled, "Please re-run the archive.php Piwik script in the crontab to refresh the reports" or similar / feel free to edit

@anonymous-matomo-user
Copy link

In b613d35: Use the Piwik API instead of directly accessing the database.

refs #3299

@anonymous-matomo-user
Copy link

In 011794a: Check for browser archiving in Controller.php

Show text according to browser archiving setting.

fixes #3299

@halfdan
Copy link
Member

halfdan commented Feb 4, 2013

@capedfuzz, hope you didn't invest much time in this. Needed the VisitorGenerator for Alerts so I took a few minutes to refactor it.

@mattab
Copy link
Member Author

mattab commented Feb 7, 2013

Nice one!

@mattab mattab added this to the 1.11 - Piwik 1.11 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

3 participants