New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sound on new visit and on click #3308
Comments
Attachment: Drop the archive's contents into plugins/Live/templates |
There's no license, attribution, or source specified for the .mp3 files. |
Thank you for the submission. We definitely would need to use open music released under compatible license. |
Sorry for the delay guys. I'm not very familiar with licenses but I chose both Creative Commons sounds. The click sound notification is licensed under the Creative Commons Attribution License and was sourced from here: The new visitor sound is an edited version of the last note of the following sound: And this is licensed under the Creative Commons 0 License. You can get more details of the licenses at the links above. Does this help? |
Hi organicAnt, matt asked me to take a look at your patch. I don't think it can be applied as is, since the change will likely annoy many existing users. Can you make the following additions to your patch?
Notes on the patch:
Let me know if you've got any questions. Looking forward to seeing your next patch :) |
Attachment: Live widget sound notifications. Patch includes sounds and on/off button images. |
Hi capedfuzz, I've added an on/off sound button and also reworked the play/pause functionality so that now we have a single switch button instead of having separate buttons for pausing/playing. I'm afraid that I couldn't figure out how to get the audio setting stored as you suggested using global.ini.php (I'm primarily a front end developer). I created a .diff patch but (being new to svn) I noticed the images and sound files were not included in the patch so I zipped them all with it. Apologies if the tab width is still wrong, I double checked in Komodo and it is setup to use 4 spaces tabbing (8 pixels wide each tab). I hope this is somewhat useful and that I didn't forget to include anything. Let me know if otherwise : ) |
Hi organicAnt, here's my review of your new patch:
Smaller issues:
|
@OrganicAnt Did you have a chance to look at the review? we'd love to include your patch in, let us know if you're keen to modify it. Cheers! |
Hi Interesting plugin. Do you know how this could be configured to play a sound on certain conditions. For example if your visitor had come from a particular campaign or country? Thanks Replying to organicAnt:
|
As requested by matt, here's the patch for the Live plugin, which adds sound to the Visitors in real time widget.
There forum thread where this patch originated is here: http://forum.piwik.org/read.php?2,91743
(Apologies if the patch isn't in accordance with the format required by piwik's process, I'm new around here.)
The text was updated successfully, but these errors were encountered: