Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Piwik_Archive_Single::preFetchBlob can select extra unnecessary blobs #3311

Closed
diosmosis opened this issue Aug 9, 2012 · 2 comments
Closed
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@diosmosis
Copy link
Member

The preFetchBlob method in Piwik_Archive_Single uses LIKE '$name%' to select subtable blobs w/ the main blob. Sometimes this can result in selecting the wrong blobs. For example, selecting blobs for 'Actions_actions' will select blobs for 'Actions_actions_url*' as well. This shouldn't happen.

@diosmosis
Copy link
Member Author

(In [7095]) Fixes #3311, use more granular SELECT in Piwik_Archive_Single::preFetchBlob & add test to make sure extra blobs are not selected.

@diosmosis
Copy link
Member Author

(In [7099]) Refs #3311, clarify test case.

@diosmosis diosmosis added this to the 1.9 -- Piwik 1.9 milestone Jul 8, 2014
@diosmosis diosmosis self-assigned this Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

1 participant