Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ViewDataTable disableFooter breaks RowPicker in evolution graph #3313

Closed
anonymous-matomo-user opened this issue Aug 10, 2012 · 2 comments
Closed
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. worksforme The issue cannot be reproduced and things work as intended.
Milestone

Comments

@anonymous-matomo-user
Copy link

This is a problem of the evolution graph I encountered while developing a plugin with Piwik 1.8.2.

The problem is that an evolution graph with its footer disabled fails to process changes in the rows/columns to display.

To reproduce this bug, modify the method getEvolutionGraph in Piwik_Referers_Controller. After the first line where it creates the view with

$view = $this->getLastUnitGraph($this->pluginName, FUNCTION, 'Referers.getRefererType');

add the following line:

$view->disableFooter();

Open Piwik and go to Referers/Overview. Mouse over the Metrics/Records selection button and tick the Website checkbox.

The widget displays the loading animation but it fails to display the data.
Keywords: evolution graph disable footer

@mattab
Copy link
Member

mattab commented Aug 11, 2012

Disabling the footer shouldn't prevent non-footer features from working indeed, thanks for the report.

@mattab
Copy link
Member

mattab commented Jan 13, 2014

we shall fix it when it will be a core use case. if you have a patch, please send a pull request we would appreciate!

@anonymous-matomo-user anonymous-matomo-user added this to the 2.x - The Great Piwik 2.x Backlog milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. worksforme The issue cannot be reproduced and things work as intended.
Projects
None yet
Development

No branches or pull requests

3 participants