#3316 closed New feature (fixed)

Option to disable seriesPicker for jqPlot

Reported by: chmielot Owned by: capedfuzz
Priority: normal Milestone: 1.10 - Piwik 1.10
Component: Core Keywords:
Cc: Sensitive: no

Description

Use case:
Using Widgetize-Plugin to display certain widgets on a website:

<div id="widgetIframe">
<iframe width="100%" 
    height="350" 
    src="http://host/piwik/index.php?module=Widgetize&action=iframe&columns[]=nb_visits,nb_pageviews&moduleToWidgetize=VisitsSummary&actionToWidgetize=getEvolutionGraph&idSite=1&period=month&date=today&disableLink=1&widget=1&seriesPicker=0" 
    scrolling="no" 
    frameborder="0" 
    marginheight="0" 
    marginwidth="0" 
    id="visitssum"></iframe>
</div>

This widget should be a limited version of the real piwik widgets, so you want to disable other series for the graph. Currently there is no option to disable the series picker in jqPlot, it is always activated as long as there are other series types for the requested graph.

I am aware of the fact that the URL can be manipulated to show other graph types. This is not important as the end user is assumed to not be able to do it. On the other hand, this could be prevented by apache rules for example.

This patch allows to set request parameter "seriesPicker" to 0 to disable the seriesPicker.

Attachments (2)

3316-seriespicker.diff (699 bytes) - added by chmielot 21 months ago.
3316-seriesPicker_v2.diff (716 bytes) - added by chmielot 20 months ago.
Correct patch!

Download all attachments as: .zip

Change History (8)

Changed 21 months ago by chmielot

comment:1 Changed 21 months ago by chmielot

Please review

comment:2 Changed 21 months ago by vipsoft (robocoder)

  • Milestone set to 1.8.3 - Piwik 1.8.3

comment:3 Changed 20 months ago by chmielot

The implementation just worked for evolution graphs. Pie charts overwrite the settings in core/Controller.php.
New implementation sets selectableColumns in core/ViewDataTable/GenerateGraphData and affects all types of graphs.
This is a new patch which doesn't revert the old changes. Please tell me if a patch with reverts is needed.

Changed 20 months ago by chmielot

Correct patch!

comment:4 Changed 18 months ago by matt (mattab)

  • Owner set to capedfuzz

Please review the patch to apply the best solution.

Also update & add the new parameter in the Analytics Widgets doc.

parameter name should be "showSeriesPicker" ?

Last edited 18 months ago by matt (previous) (diff)

comment:5 Changed 18 months ago by chmielot

matt, how can I update the doc? Shall I review the patch again or do you mean somebody else?

comment:6 Changed 17 months ago by capedfuzz (diosmosis)

  • Resolution set to fixed
  • Status changed from new to closed

(In [7537]) Fixes #3316, applied modified version of @chmielot's patch to add showSeriesPicker query parameter which can be used to enable/disable the series picker on graphs.

Note: See TracTickets for help on using tickets.