Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins API: let plugins customize datatable footer icons #3317

Closed
chmielot opened this issue Aug 13, 2012 · 8 comments
Closed

Plugins API: let plugins customize datatable footer icons #3317

chmielot opened this issue Aug 13, 2012 · 8 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone

Comments

@chmielot
Copy link

Use case:

Using Widgetize-Plugin to display certain widgets on a website:

<div id="widgetIframe">
<iframe width="100%" 
    height="350" 
    src="http://host/piwik/index.php?module=Widgetize&action=iframe&columns[]=nb_visits,nb_pageviews&moduleToWidgetize=VisitsSummary&actionToWidgetize=getEvolutionGraph&idSite=1&period=month&date=today&disableLink=1&widget=1&show_export_as_image_icon=0" 
    scrolling="no" 
    frameborder="0" 
    marginheight="0" 
    marginwidth="0" 
    id="visitssum"></iframe>
</div>

The show_export_as_image_icon setting has no effect, because the value (first set in parent class from request parameters) is overwritten in core/ViewDataTable/GenerateGraphHTML.php

I don't see why this shouldn't be allowed here. The patch fixes this problem.

@chmielot
Copy link
Author

Attachment:
3317-show_export_as_image_icon.diff

@chmielot
Copy link
Author

Please review

@mattab
Copy link
Member

mattab commented Oct 20, 2012

So, do you want to be able to hide the "Export as image button" ? is it what you are requesting? we could add a new parameter "showExportAsImage".

See similar #3316

@chmielot
Copy link
Author

matt, this patch just fixes available functionality. Could be of course, that the existing show_export_as_image_icon parameter is deprecated. #3316 adds completely new functionality. Please also see #3327, which is similar.

@mattab
Copy link
Member

mattab commented Apr 4, 2013

Generalizing the task so we can check that all features/icons of the datatable are customized by plugins reusing the Piwik framework.

@anonymous-matomo-user
Copy link

In 83261e0: Refs #4041, #3317, #4077, allow different visualizations to specify their own loading logic (when the appropriate footer icon is clicked) and fix a couple UI bugs in treemap.

@anonymous-matomo-user
Copy link

In c0768bf: Refs #4041, #3317, allow visualization ID to be whole class name, allow footer icons to be customized per report/visualization, made visitor log a new visualization and removed the datatable_template display property.

@anonymous-matomo-user
Copy link

In 6042103: Fixes #3317, allow plugins/themes to specify their own ViewDataTable footer icons or modify existing ones.

@chmielot chmielot added this to the 2.x - The Great Piwik 2.x Backlog milestone Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
…nt visualizations to specify their own loading logic (when the appropriate footer icon is clicked) and fix a couple UI bugs in treemap.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
…hole class name, allow footer icons to be customized per report/visualization, made visitor log a new visualization and removed the datatable_template display property.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
…DataTable footer icons or modify existing ones.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

No branches or pull requests

3 participants