New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transitions: reports about previous and following actions for each page URL #3332
Comments
The plugin fakes an instance of Piwik_ArchiveProcessing_Day in order to use archiving code for live querying (later pre-archiving might be added). The plugin uses Piwik_ArchiveProcessing_Day::query*ByDimension. These methods have been extended in #3330. From the returned data, only nb_actions is used in Transitions. In particular, count(distinct idvisit) and count(distinct idvisitor) is processed in MySQL and not used in the report. Count distinct takes significantly more time and memory than other aggregation functions. Should we extend the query*ByDimension methods to limit the columns in the result? The signatures are already rather long after #3330. I'm not sure what's best... |
(In [6811]) refs #3332: Preparations for Transitions
|
(In [6812]) refs #3332 Transitions
|
(In [6813]) refs #3332: properties for previous commit |
In case you're wondering: I can't commit properties from git svn. I have to commit with git svn, then update, propset & commit with svn. That's why I always set properties in a separate commit. |
(In [6843]) refs #3332 row actions registry: preparations for Transitions UI
|
(In [6844]) refs #3332: Transitions UI (row action for pages report + popover) |
(In [6845]) refs #3332 properties |
So here's the current state of the Transitions UI. The plugin adds a new row action to the pages report which opens the Transitions popover. It would be great if some of you could give it a try and report back to me. I'm especially interested in performance. How long does it take to load the popover on how many pageviews per day? Please don't take too much time writing suggestions for the UI itself. We already have lots of changes planned. Once that's done and you still have suggestions, please let me know. The icon that launches the popover is just a placeholder. I'd like to have an icon that looks a bit like the popover with curvy bars going in and out of a box. Unfortunately, everything I came up with didn't look good. Do we have someone who could design the icon? |
(In [6846]) refs #3332 more work on Transitions
|
Even though we did URL normalization recently, we still have some problems with non-normalized URLs in this plugin. URLs with different domains or different strings after the hash have different idactions but end up in the same row in the pages report. This causes inconsistency because the numbers from the pages report and the ones derived on the basis of the idaction don't match. Since the Transitions report mixes both, that's bad. One possible solution would be to add two options to the configuration:
When both these options are enabled, the problem should be gone. When enabling one of the options would break the links for a user, he can disable them. Honestly, I think most users wouldn't care very much about broken links. But with the options, it's up to them. An alternative solution would be this: in order to avoid conflicting numbers from the pages report and the Transitions plugin's archiving, we don't reuse the pages report and have to get the main metrics from the logs. In particular, we're talking about #hits, #entries, #exits. it should be possible to get #hits by summing up the other numbers. So what do you think? Which option's better? Are there other alternatives? |
(In [6853]) refs #3332 Transitions
|
(In [6854]) refs #3332 updated expected test output for Transitions |
(In [6855]) refs #3332
|
If it's one more parameter and not too tricky, I'd say it's better to put it in. It might earn a few milliseconds here and there, which would tremendously help for pre-archiving (where milliseconds quickly make minutes ;)) So please add the parameter, and unit test, and all good. It's complicated but it has to be.
Hash tags: good point, I put a feature request in: #3232 - comment there if you have to add info. Different domains: I think we can leave with this limitation for now. Users can use setCustomUrl in javascript to correct input URL if necessary... |
Attachment: Example Transition Aug 22nd |
Attachment: Icon on hover could have colors and show a flow ? or something else, like a button and a text label ? |
Not recording the hash part in the database by default (as you suggested in #3232) would help lots. Thanks for creating such a lovely icon by the way - lol! Seriously, there must be someone who is good at this kind of thing and can design an icon for us. Also, why are my commits not showing up in the ticket anymore? I made four today referring this ticket and none are shown here. |
Replying to matts E-Mail:
The popover already conatins a lot of text and the title would make it look really packed. Also the title is way too big compared to the other text in the popover. Imho it looks quite ugly. Besides, the page we are looking at is already indicated in the center box. So I'd rather not set the title. OK? |
(In []) refs #3332
|
Timo, WOOW! Excellent feature, awesome potential and I really like the first implementation you made! Here is my feedback regarding the User Interface. It took 3-4 seconds max (often 1s) to load for the homepage with 1500 pageviews. It is definitely super responsive ons mall websites, very nice speed! Benefits of RankingQuery and URL normalization are huge. Very well done.. :-) impressed by your work & the performance side of it. Here is full review of using the feature review & making it more accessible:
Other review:
More reviews to come later |
(In [6987]) Removing temporarily Transitions plugin from release Refs #3332 on the demo, when enabling the plugin, it was creating a JS error in the merged JS file |
(In [6988]) Removing temporarily Transitions plugin from release Refs #3332 |
Some general comments about the reviews (also the ones received via e-mail)
|
(In [7032]) refs #3332 adding Transitions again |
(In [7033]) refs #3332 highlighting groups on hover in Transitions |
After the last commit, when you hover a goup title, it highlights the metric in the center. Also, the group is highlighted when you hover the metric in the center box. This makes the mapping between the groups and the center box easier. |
(In [7035]) refs #3332 nicer loading message for transitions, introducing a general popover helper |
(In [7037]) will release 1.9 B to test transitions on demo and bring back Row evolution on demo Refs #3332 |
(In [7137]) refs #3332
|
(In [7143]) Refs #3332 Fixing JS error on admin pages FYI since Piwik_Controller is only used for reports controllers (where as Piwik_Controller_Admin is for admin controllers), the separator wasn't set on admin screens |
(In [7148]) Refs #3332 This will set the metadata on the URL with the most page views, for daily reports |
(In [7160]) Refs #3332 Hopefully, fixing all problems with URL being incorrectly aggregated! Thanks Timo for the hint and bug in previous algorithm |
Test message notification? |
It seems that all "data bugs" should now be fixed, please notify me if you find any further issue! Timo, I noticed there is a small problem: unicode characters don't get displayed, instead the URL encoded version is displayed, in Transitions. For example in this URL See attached screenshot |
Attachment: |
Attachment: |
Replying to matt:
The UTF8 chars are shown in the label of the report but the link is urlencoded. That's why it's urlencoded in transitions. I'm pretty sure the urlencoded version is also what's in the database because Transitions looks for this version and works. So what's the best behavior? Should we urldecode once before displaying urls in Transitions? What does the actions report do with the label? |
(In [7165]) refs #3332 Transitions help button linking to doc page |
(In [7166]) refs #3332: url decode in transitions in order to display utf8 urls |
Please test the latest commit on the demo. The UTF8 chars should work now. I tested the code with a url that contains both utf8 chars and an html tag. UTF8 encoding and XSS protection ist working in the center box, side boxes and the tooltip. Nevertheless, please test and review closely. |
OK guys, this is it. If you can't find more problems, we can close the ticket! Yay!!! |
(In [7189]) fixes #3332
|
(In [7219]) Enabling Transitions plugin by default! fixes #3332 |
(In [7306]) Refs #3332 |
See #3899 Transitions support for Downloads and Outlinks so we can see which pages lead to file download, or on which pages was an outlink clicked. This would be powerful! |
Awesome feature: Analytics Previous / next pages
For each page URL, this plugin reports the top X
The information is given in a popover which can be launched via a table action on the pages report.
The text was updated successfully, but these errors were encountered: